First batch of NLU signals

[bfilar]

No description provided.

[jkamdjou]

l f g

[bfilar]

Ready for review

[morriscode]

These look good to me. The only thing I question is the use of Tags. None of the other signals have any tags on them, I'm not sure if those actually do anything, or if they're helpful in your model, or even if they work on signals, I assumed they would as it's probably the same schema, but I don't know.

[bfilar]

that's a fair point. i should probably add them

[morriscode]

that's a fair point. i should probably add them

these already have them, but none of the other signals do, if we're saying we want tags for all signals. The tags almost feel redundant to the name, which is why I think we didn't add them before.

If having tags helps you lets add them to all signals, but if it's just superficial lets remove them from this pr?

[bfilar]

Oh I see what you're saying. Let's get them in as they could be useful indicators when observed with other signals

[bfilar]

Based on internal testing from @rw-access this should be good to merge. Someone review & give a 👍

[rw-access]

FWIW this PR wasn't blocked before testing and isn't now, so don't let me hold you up!

[morriscode]