-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some html.screenshot usages #1031
Conversation
and any(file.explode(.), | ||
any(ml.logo_detect(file.html_screenshot(..)).brands, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will evaluate the exact same every time so shouldn't be in the loop.
or ..file_type == "html" | ||
or ..content_type == "text/html" | ||
) | ||
and any(ml.logo_detect(file.html_screenshot(..)).brands, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this entirely. We currently can't look at raw files in archives. This one is referencing the archive attachment.
FYI @aidenmitchell.
I didn't look at any other rules to check for invalid usage of
..
insidefile.explode(.)
.Remember that
..
inside afile.explode
is referring to the attachment, not the exploded file. In the archive case, the attachment is the archive file.