Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/1649 JanusGraph persistence documentation #77

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

issues/1649 JanusGraph persistence documentation #77

wants to merge 7 commits into from

Conversation

sbespalov
Copy link
Member

@sbespalov sbespalov commented Mar 18, 2020 •
edited by steve-todorov
Loading

@ghost
Copy link

ghost commented Mar 18, 2020 •
edited by ghost
Loading

Congratulations 🍻. DeepCode analyzed your code in 0.244 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@sbespalov sbespalov marked this pull request as ready for review March 18, 2020 08:31
carlspring
carlspring reviewed Mar 18, 2020
View reviewed changes
docs/developer-guide/getting-started-with-persistence.md
MyEntity myEntity = (MyEntity) o;
return __.<Vertex, Object>project("uuid", "age")
.by(__.enrichPropertyValue("uuid"))
.by(__.enrichPropertyValue("age"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you perhaps add some details about these oddly named classes/variables? (I know it was Gremlin, or Cypher, but it would probably help others get a better understanding of what this black magic spell is all about :) ). Thanks! :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@carlspring
Copy link
Member

carlspring commented Mar 18, 2020 •
edited
Loading

A couple of things:

  • Could you perhaps add some more details on what we're using Groovy for in Gremlin?
  • How to use the UI that @steve-todorov added for the queries. (Maybe a screenshot, or two...?).

@steve-todorov steve-todorov force-pushed the issues/1649 branch 4 times, most recently from 5744510 to 50f4d15 Compare March 18, 2020 21:22
@steve-todorov
Copy link
Member

This looks very good to me! I've fixed the netlify deployment so there is also a live preview.

RE Database console UI/Screenshots - we should probably wait until we get to that part. We have the UI, but we need to do some more work there (i.e. make it so that connections to the gremlin server are going through spring security so that only admins can connect; fix strongbox/strongbox#1669 once the time comes)

@carlspring
Copy link
Member

Okay! Cool, thanks for clarifying! :)

@sbespalov
Copy link
Member Author

@carlspring

Could you perhaps add some more details on what we're using Groovy for in Gremlin?

actually we don't :) I think it required for Gremlin Server

@sbespalov sbespalov mentioned this pull request Apr 7, 2020
Open
31 tasks
@carlspring
Copy link
Member

It seems this pull request has become out-of-date.

@sbespalov
Copy link
Member Author

It seems this pull request has become out-of-date.

@carlspring fixed

@sbespalov sbespalov mentioned this pull request May 11, 2020
Open
10 tasks
@carlspring
Copy link
Member

Thanks, @steve-todorov ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlspring carlspring carlspring left review comments

@steve-todorov steve-todorov Awaiting requested review from steve-todorov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbespalov @carlspring @steve-todorov