Update the CI workflow #945
Merged
+132
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied the same settings as: - stripe-samples/accept-a-payment#1385 - stripe-samples/accept-a-payment#1612
hibariya
commented
Feb 12, 2024
| @@ -6,6 +6,8 @@ export default defineConfig({ | |||
| react(), | |||
| ], | |||
| server: { | |||
| host: '0.0.0.0', | |||
| port: 3000, | |||
There was a problem hiding this comment.
@hideokamoto-stripe This changes Vite's port from 5173 to 3000. I did it because the current CI configuration expects the port 3000 for frontend servers. Also, I think keep the port unchanged from the original 3000 less confuse the users. But let me know if we should keep the default port number 🙏 In that case, we could sed the port in CI.
hibariya
commented
Feb 12, 2024
| end | ||
| within_frame first('iframe[name*=__privateStripeFrame][src*=three-ds') do | ||
| within_frame first('iframe#challengeFrame') do | ||
| click_on 'Complete' |
There was a problem hiding this comment.
It seems the 3DS UI has changed a bit 😅
|
@hideokamoto-stripe Hi Hide, I added some changes to make CI green 🍏 Also, left a couple of comments 🙏 |
|
@hideokamoto-stripe I also opened a similar PR for checkout-one-time-paymens. Could you take a look when convenient? Thanks 🙇 |
|
LGMT! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I applied the changes the same as the following PRs to the CI workflow here:
Also, I updated Flask and Capybara configurations to fix failing tests.