Added missing error handling on firehose.Init call

streamingfast · Sep 14, 2023 · e87d57c · e87d57c
1 parent 56a453e
commit e87d57c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/firehose/globals.go b/firehose/globals.go
@@ -83,7 +83,7 @@ func Init(
 	// We must check for both `nil` and `(*core.Genesis)(nil)`, latter case that is not catch by using `genesis == nil` directly
 	if !isNilInterfaceOrNilValue(genesis) {
 		GenesisConfig = genesis
-		genesisProvenance = "Geth Specific Flag"
+		genesisProvenance = "Geth Specific Flag (--<chain>)"
 	} else {
 		if genesisFilePath := genesisFile; genesisFilePath != "" {
 			file, err := os.Open(genesisFilePath)
@@ -98,7 +98,7 @@ func Init(
 			}
 
 			GenesisConfig = genesis
-			genesisProvenance = "User provider"
+			genesisProvenance = "Firehose Specific Flag (--firehose-genesis <file>)"
 		}
 	}
 

diff --git a/internal/debug/flags.go b/internal/debug/flags.go
@@ -191,15 +191,17 @@ func Setup(ctx *cli.Context, firehoseGenesis *core.Genesis, firehoseGethVersion
 		StartPProf(address, !ctx.GlobalIsSet("metrics.addr"))
 	}
 
-	firehose.Init(ctx.GlobalBool(firehoseEnabledFlag.Name),
+	if err := firehose.Init(ctx.GlobalBool(firehoseEnabledFlag.Name),
 		ctx.GlobalBoolT(firehoseSyncInstrumentationFlag.Name),
 		ctx.GlobalBool(firehoseMiningEnabledFlag.Name),
 		ctx.GlobalBool(firehoseBlockProgressFlag.Name),
 		firehoseGenesis,
 		ctx.GlobalString(firehoseGenesisFileFlag.Name),
 		func() interface{} { return new(core.Genesis) },
 		firehoseGethVersion,
-	)
+	); err != nil {
+		return fmt.Errorf("initializing firehose: %w", err)
+	}
 
 	return nil
 }