-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test sv2 ffi interface #30
Test sv2 ffi interface #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 issues related to the PR that should be added as they are not a priority but still very
relevant:
First issue:
The below should compile:
cargo test --features prop_test --features with_serde
Second issue
When implementing Arbitrary we should also implement shrink.
protocols/v2/binary-sv2/no-serde-sv2/codec/src/datatypes/non_copy_data_types/inner.rs
Show resolved
Hide resolved
protocols/v2/binary-sv2/no-serde-sv2/codec/src/datatypes/non_copy_data_types/seq_inner.rs
Show resolved
Hide resolved
protocols/v2/binary-sv2/no-serde-sv2/codec/src/datatypes/non_copy_data_types/seq_inner.rs
Show resolved
Hide resolved
protocols/v2/binary-sv2/serde-sv2/src/primitives/byte_arrays/b016m.rs
Outdated
Show resolved
Hide resolved
protocols/v2/binary-sv2/serde-sv2/src/primitives/sequences/seq0255.rs
Outdated
Show resolved
Hide resolved
protocols/v2/subprotocols/template-distribution/src/new_template.rs
Outdated
Show resolved
Hide resolved
protocols/v2/subprotocols/template-distribution/src/new_template.rs
Outdated
Show resolved
Hide resolved
protocols/v2/subprotocols/template-distribution/src/new_template.rs
Outdated
Show resolved
Hide resolved
When I run
Do you have a suggestion on how I can fix these warnings? |
Did you try |
Yes that fixed it! Ty. |
260a7ce
to
55b5b98
Compare
…_distribution lib
…_distribution lib
…plate_distribution lib
…emplate_distribution lib
…s, fix CNewTemplate errors
093a74b
to
4c1679d
Compare
No description provided.