Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jdc sigterm signalling issue #1321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix jdc sigterm signalling issue #1321

wants to merge 1 commit into from
+218 −204

Conversation

Shourya742
Copy link
Contributor

closes: #1266

@Shourya742 Shourya742 mentioned this pull request Dec 23, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,440.10
(-2.21%)		6,918.78
(93.08%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,336.60
(-1.30%)		7,835.60
(93.63%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,900.20
(-2.51%)		9,279.22
(85.14%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		887.35
(+2.32%)		941.56
(94.24%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		669.80
(-0.63%)		715.31
(93.64%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		247.27
(-0.72%)		269.94
(91.60%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.93
(-0.32%)		166.26
(94.39%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,284.50
(-1.27%)		6,745.66
(93.16%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		279.58
(-0.87%)		323.65
(86.38%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		717.02
(-1.30%)		774.02
(92.64%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		585.82
(-0.59%)		625.30
(93.69%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		206.24
(-0.08%)		223.79
(92.16%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv2

🚨 1 Alert

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		90.00
(+19.49%)		88.91
(101.23%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.10
(-0.28%)		2.23
(94.49%)		📈 view plot
🚷 view threshold		473.00
(-0.05%)		488.92
(96.74%)		📈 view plot
🚷 view threshold		733.00
(-0.36%)		757.93
(96.71%)		📈 view plot
🚷 view threshold		8.00
(+60.25%)		12.01
(66.61%)		📈 view plot
🚷 view threshold		38.00
(-1.36%)		41.53
(91.51%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.28
(+0.72%)		8.38
(98.77%)		📈 view plot
🚷 view threshold		2,137.00
(-0.01%)		2,140.48
(99.84%)		📈 view plot
🚷 view threshold		3,155.00
(-0.13%)		3,169.17
(99.55%)		📈 view plot
🚷 view threshold		38.00
(+6.97%)		41.68
(91.16%)		📈 view plot
🚷 view threshold		141.00
(+1.05%)		144.04
(97.89%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.29
(-0.20%)		6.44
(97.58%)		📈 view plot
🚷 view threshold		1,750.00
(-0.02%)		1,766.19
(99.08%)		📈 view plot
🚷 view threshold		2,550.00
(-0.07%)		2,574.59
(99.04%)		📈 view plot
🚷 view threshold		19.00
(+11.30%)		24.23
(78.42%)		📈 view plot
🚷 view threshold		104.00
(-0.55%)		108.57
(95.79%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.72
(-0.03%)		14.93
(98.57%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,710.19
(99.66%)		📈 view plot
🚷 view threshold		6,748.00
(-0.12%)		6,785.72
(99.44%)		📈 view plot
🚷 view threshold		54.00
(+20.27%)		60.92
(88.64%)		📈 view plot
🚷 view threshold		220.00
(-0.54%)		226.36
(97.19%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.74
(+0.57%)		28.00
(99.07%)		📈 view plot
🚷 view threshold		10,645.00
(+0.40%)		10,686.96
(99.61%)		📈 view plot
🚷 view threshold		15,500.00
(+0.44%)		15,574.62
(99.52%)		📈 view plot
🚷 view threshold		96.00
(+15.45%)		98.10
(97.86%)		📈 view plot
🚷 view threshold		336.00
(+0.22%)		342.39
(98.13%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.41
(+0.47%)		4.55
(96.92%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,476.92
(98.92%)		📈 view plot
🚷 view threshold		2,158.00
(-0.11%)		2,183.65
(98.83%)		📈 view plot
🚷 view threshold		10.00
(+23.67%)		13.54
(73.87%)		📈 view plot
🚷 view threshold		63.00
(+0.61%)		67.08
(93.91%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		13.97
(-0.32%)		14.19
(98.45%)		📈 view plot
🚷 view threshold		5,064.00
(-0.00%)		5,079.92
(99.69%)		📈 view plot
🚷 view threshold		7,322.00
(-0.06%)		7,351.36
(99.60%)		📈 view plot
🚷 view threshold		42.00
(+16.69%)		47.09
(89.19%)		📈 view plot
🚷 view threshold		184.00
(-1.08%)		190.99
(96.34%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.88
(+0.84%)		23.00
(99.45%)		📈 view plot
🚷 view threshold		8,040.00
(+0.11%)		8,053.90
(99.83%)		📈 view plot
🚷 view threshold		11,683.00
(-0.00%)		11,711.07
(99.76%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		90.00
(+19.49%)		88.91
(101.23%)		📈 view plot
🚷 view threshold		307.00
(+1.10%)		311.17
(98.66%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.68
(-0.22%)		4.78
(97.75%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.92
(98.95%)		📈 view plot
🚷 view threshold		2,277.00
(-0.05%)		2,299.53
(99.02%)		📈 view plot
🚷 view threshold		11.00
(+16.46%)		15.53
(70.84%)		📈 view plot
🚷 view threshold		67.00
(-0.72%)		70.01
(95.70%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.18
(+0.19%)		16.31
(99.22%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.92
(99.73%)		📈 view plot
🚷 view threshold		8,655.00
(-0.10%)		8,691.58
(99.58%)		📈 view plot
🚷 view threshold		49.00
(+22.48%)		54.22
(90.37%)		📈 view plot
🚷 view threshold		208.00
(-0.07%)		211.89
(98.16%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.73
(+0.41%)		35.90
(99.53%)		📈 view plot
🚷 view threshold		14,888.00
(+0.16%)		14,912.40
(99.84%)		📈 view plot
🚷 view threshold		21,865.00
(+0.12%)		21,910.76
(99.79%)		📈 view plot
🚷 view threshold		113.00
(+21.20%)		116.77
(96.77%)		📈 view plot
🚷 view threshold		380.00
(+0.15%)		385.06
(98.69%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.29
(-1.93%)		8.68
(95.53%)		📈 view plot
🚷 view threshold		3.66
(-1.84%)		3.86
(94.85%)		📈 view plot
🚷 view threshold		5.11
(-2.21%)		5.45
(93.82%)		📈 view plot
🚷 view threshold		13.00
(+59.85%)		15.72
(82.68%)		📈 view plot
🚷 view threshold		89.00
(-2.26%)		96.00
(92.71%)
get_submit📈 view plot
🚷 view threshold		95.21
(-0.16%)		95.68
(99.51%)		📈 view plot
🚷 view threshold		59.26
(-0.26%)		59.71
(99.26%)		📈 view plot
🚷 view threshold		85.07
(-0.31%)		85.82
(99.13%)		📈 view plot
🚷 view threshold		54.00
(+21.63%)		60.06
(89.91%)		📈 view plot
🚷 view threshold		282.00
(+0.59%)		290.17
(97.19%)
get_subscribe📈 view plot
🚷 view threshold		7.80
(-2.52%)		8.24
(94.65%)		📈 view plot
🚷 view threshold		2.76
(-2.16%)		2.94
(93.70%)		📈 view plot
🚷 view threshold		3.83
(-2.54%)		4.14
(92.53%)		📈 view plot
🚷 view threshold		16.00
(+31.03%)		20.31
(78.78%)		📈 view plot
🚷 view threshold		111.00
(-3.02%)		117.89
(94.16%)
serialize_authorize📈 view plot
🚷 view threshold		12.07
(-1.54%)		12.51
(96.47%)		📈 view plot
🚷 view threshold		5.24
(-1.21%)		5.43
(96.56%)		📈 view plot
🚷 view threshold		7.28
(-1.47%)		7.60
(95.78%)		📈 view plot
🚷 view threshold		13.00
(+31.23%)		18.47
(70.38%)		📈 view plot
🚷 view threshold		135.00
(-1.99%)		142.29
(94.88%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.50
(-0.85%)		25.18
(97.29%)		📈 view plot
🚷 view threshold		9.79
(-0.80%)		10.02
(97.70%)		📈 view plot
🚷 view threshold		13.79
(-0.95%)		14.18
(97.25%)		📈 view plot
🚷 view threshold		35.00
(-1.71%)		45.57
(76.81%)		📈 view plot
🚷 view threshold		301.00
(-0.70%)		313.08
(96.14%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.12
(-0.67%)		30.73
(98.03%)		📈 view plot
🚷 view threshold		11.99
(-0.57%)		12.19
(98.34%)		📈 view plot
🚷 view threshold		16.96
(-0.68%)		17.30
(98.02%)		📈 view plot
🚷 view threshold		57.00
(+2.50%)		66.98
(85.11%)		📈 view plot
🚷 view threshold		368.00
(-0.73%)		379.25
(97.03%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.43
(-0.02%)		126.78
(99.72%)		📈 view plot
🚷 view threshold		73.12
(-0.19%)		73.53
(99.44%)		📈 view plot
🚷 view threshold		104.75
(-0.25%)		105.49
(99.30%)		📈 view plot
🚷 view threshold		121.00
(+13.99%)		125.54
(96.39%)		📈 view plot
🚷 view threshold		602.00
(+0.78%)		608.05
(99.00%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.75
(-0.57%)		28.42
(97.64%)		📈 view plot
🚷 view threshold		9.58
(-0.62%)		9.76
(98.14%)		📈 view plot
🚷 view threshold		13.52
(-0.79%)		13.83
(97.70%)		📈 view plot
🚷 view threshold		74.00
(+15.19%)		77.63
(95.33%)		📈 view plot
🚷 view threshold		396.00
(-0.71%)		410.64
(96.43%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.19
(-0.05%)		115.71
(99.54%)		📈 view plot
🚷 view threshold		67.89
(-0.26%)		68.41
(99.24%)		📈 view plot
🚷 view threshold		97.36
(-0.33%)		98.28
(99.06%)		📈 view plot
🚷 view threshold		73.00
(+13.30%)		85.72
(85.16%)		📈 view plot
🚷 view threshold		499.00
(+1.27%)		501.78
(99.45%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.11
(-0.90%)		23.84
(96.94%)		📈 view plot
🚷 view threshold		8.13
(-0.76%)		8.31
(97.77%)		📈 view plot
🚷 view threshold		11.43
(-0.90%)		11.74
(97.32%)		📈 view plot
🚷 view threshold		40.00
(+3.85%)		50.25
(79.60%)		📈 view plot
🚷 view threshold		328.00
(-0.99%)		342.83
(95.67%)
serialize_submit📈 view plot
🚷 view threshold		99.67
(-0.13%)		100.13
(99.54%)		📈 view plot
🚷 view threshold		61.33
(-0.23%)		61.73
(99.34%)		📈 view plot
🚷 view threshold		87.93
(-0.29%)		88.64
(99.19%)		📈 view plot
🚷 view threshold		59.00
(+24.15%)		66.15
(89.19%)		📈 view plot
🚷 view threshold		327.00
(+0.61%)		335.45
(97.48%)
serialize_subscribe📈 view plot
🚷 view threshold		11.28
(-1.07%)		11.60
(97.20%)		📈 view plot
🚷 view threshold		4.11
(-1.36%)		4.28
(95.97%)		📈 view plot
🚷 view threshold		5.69
(-1.71%)		6.00
(94.93%)		📈 view plot
🚷 view threshold		18.00
(+33.41%)		23.18
(77.66%)		📈 view plot
🚷 view threshold		157.00
(-0.81%)		163.45
(96.05%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.61
(-1.26%)		58.56
(76.17%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		87.80
(+12.00%)		105.68
(83.08%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(+0.01%)		14.71
(99.67%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		261.61
(-1.77%)		288.90
(90.55%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		602.66
(-1.58%)		646.33
(93.24%)
client_sv2_open_channel📈 view plot
🚷 view threshold		165.37
(+0.28%)		175.86
(94.04%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		282.13
(-1.10%)		308.85
(91.35%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		376.93
(-1.70%)		408.53
(92.27%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		159.98
(+0.07%)		170.61
(93.77%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		440.79
(-6.26%)		553.67
(79.61%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		982.97
(-1.64%)		1,142.41
(86.04%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 19.29%. Comparing base (e8d76d6) to head (6bb7eb0).

Files with missing lines Patch % Lines
roles/jd-client/src/lib/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1321   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         164      164           
  Lines       10852    10852           
=======================================
  Hits         2094     2094           
  Misses       8758     8758
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <0.00%> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <0.00%> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from 3aa0262 to 6bb7eb0 Compare December 23, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate ghost processes in tproxy and JDC
1 participant
@Shourya742