subprotocol crates no_std support
#1315
Merged
+31
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher Report
|
| Branch | subprotocols_no_std |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2.20 (+4.14%) | 2.23 (98.57%) | 📈 view plot 🚷 view threshold | 473.00 (-0.05%) | 488.92 (96.74%) | 📈 view plot 🚷 view threshold | 732.00 (-0.49%) | 757.93 (96.58%) | 📈 view plot 🚷 view threshold | 6.00 (+20.57%) | 11.95 (50.21%) | 📈 view plot 🚷 view threshold | 41.00 (+6.36%) | 41.62 (98.50%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8.32 (+1.23%) | 8.38 (99.25%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.01%) | 2,140.48 (99.84%) | 📈 view plot 🚷 view threshold | 3,152.00 (-0.23%) | 3,169.28 (99.45%) | 📈 view plot 🚷 view threshold | 40.00 (+12.55%) | 41.79 (95.72%) | 📈 view plot 🚷 view threshold | 142.00 (+1.76%) | 144.09 (98.55%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6.39 (+1.41%) | 6.44 (99.12%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.02%) | 1,766.19 (99.08%) | 📈 view plot 🚷 view threshold | 2,547.00 (-0.19%) | 2,574.60 (98.93%) | 📈 view plot 🚷 view threshold | 19.00 (+11.30%) | 24.23 (78.42%) | 📈 view plot 🚷 view threshold | 107.00 (+2.29%) | 108.65 (98.48%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14.84 (+0.78%) | 14.93 (99.35%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.01%) | 4,710.19 (99.66%) | 📈 view plot 🚷 view threshold | 6,748.00 (-0.12%) | 6,785.72 (99.44%) | 📈 view plot 🚷 view threshold | 50.00 (+11.44%) | 60.75 (82.30%) | 📈 view plot 🚷 view threshold | 224.00 (+1.26%) | 226.44 (98.92%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27.86 (+1.00%) | 28.01 (99.47%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.40%) | 10,686.96 (99.61%) | 📈 view plot 🚷 view threshold | 15,500.00 (+0.44%) | 15,574.62 (99.52%) | 📈 view plot 🚷 view threshold | 92.00 (+10.68%) | 97.84 (94.03%) | 📈 view plot 🚷 view threshold | 340.00 (+1.40%) | 342.54 (99.26%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4.48 (+2.00%) | 4.56 (98.37%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.02%) | 1,476.92 (98.92%) | 📈 view plot 🚷 view threshold | 2,156.00 (-0.21%) | 2,183.65 (98.73%) | 📈 view plot 🚷 view threshold | 10.00 (+23.67%) | 13.54 (73.87%) | 📈 view plot 🚷 view threshold | 65.00 (+3.78%) | 67.15 (96.80%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14.08 (+0.43%) | 14.19 (99.19%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.00%) | 5,079.92 (99.69%) | 📈 view plot 🚷 view threshold | 7,318.00 (-0.11%) | 7,351.41 (99.55%) | 📈 view plot 🚷 view threshold | 43.00 (+19.44%) | 47.14 (91.21%) | 📈 view plot 🚷 view threshold | 187.00 (+0.52%) | 190.99 (97.91%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22.85 (+0.73%) | 23.00 (99.35%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.11%) | 8,053.90 (99.83%) | 📈 view plot 🚷 view threshold | 11,689.00 (+0.05%) | 11,711.17 (99.81%) | 📈 view plot 🚷 view threshold | 84.00 (+11.59%) | 88.46 (94.96%) | 📈 view plot 🚷 view threshold | 307.00 (+1.10%) | 311.17 (98.66%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4.74 (+1.13%) | 4.79 (99.05%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.02%) | 1,517.92 (98.95%) | 📈 view plot 🚷 view threshold | 2,276.00 (-0.10%) | 2,299.53 (98.98%) | 📈 view plot 🚷 view threshold | 10.00 (+5.96%) | 15.51 (64.49%) | 📈 view plot 🚷 view threshold | 69.00 (+2.22%) | 70.06 (98.49%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16.24 (+0.56%) | 16.31 (99.57%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.00%) | 5,978.92 (99.73%) | 📈 view plot 🚷 view threshold | 8,655.00 (-0.10%) | 8,691.58 (99.58%) | 📈 view plot 🚷 view threshold | 47.00 (+17.52%) | 54.12 (86.85%) | 📈 view plot 🚷 view threshold | 210.00 (+0.88%) | 211.94 (99.08%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35.77 (+0.51%) | 35.90 (99.62%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.16%) | 14,912.40 (99.84%) | 📈 view plot 🚷 view threshold | 21,871.00 (+0.14%) | 21,910.99 (99.82%) | 📈 view plot 🚷 view threshold | 105.00 (+12.69%) | 116.29 (90.29%) | 📈 view plot 🚷 view threshold | 382.00 (+0.68%) | 385.11 (99.19%) |
|
| Branch | subprotocols_no_std |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,433.00 (-2.31%) | 6,920.62 (92.95%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,270.30 (-2.16%) | 7,846.96 (92.65%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 7,822.90 (-3.43%) | 9,286.87 (84.24%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 880.37 (+1.54%) | 940.26 (93.63%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 674.12 (-0.01%) | 715.31 (94.24%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 246.91 (-0.86%) | 269.95 (91.46%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 158.19 (+0.45%) | 166.31 (95.12%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,250.80 (-1.79%) | 6,750.11 (92.60%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 282.33 (+0.07%) | 323.69 (87.22%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 758.20 (+4.16%) | 781.12 (97.07%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 585.00 (-0.72%) | 625.33 (93.55%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 209.35 (+1.37%) | 224.06 (93.44%) |
|
| Branch | subprotocols_no_std |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary 1e3 x instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary 1e3 x accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8.48 (+0.32%) | 8.67 (97.78%) | 📈 view plot 🚷 view threshold | 3.66 (-1.84%) | 3.86 (94.85%) | 📈 view plot 🚷 view threshold | 5.11 (-2.27%) | 5.45 (93.77%) | 📈 view plot 🚷 view threshold | 10.00 (+23.31%) | 15.60 (64.12%) | 📈 view plot 🚷 view threshold | 95.00 (+4.28%) | 96.14 (98.82%) |
| get_submit | 📈 view plot 🚷 view threshold | 95.34 (-0.03%) | 95.68 (99.65%) | 📈 view plot 🚷 view threshold | 59.26 (-0.26%) | 59.71 (99.26%) | 📈 view plot 🚷 view threshold | 85.08 (-0.30%) | 85.82 (99.14%) | 📈 view plot 🚷 view threshold | 43.00 (-2.96%) | 59.75 (71.97%) | 📈 view plot 🚷 view threshold | 287.00 (+2.36%) | 290.37 (98.84%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7.96 (-0.56%) | 8.23 (96.62%) | 📈 view plot 🚷 view threshold | 2.76 (-2.16%) | 2.94 (93.70%) | 📈 view plot 🚷 view threshold | 3.83 (-2.59%) | 4.14 (92.48%) | 📈 view plot 🚷 view threshold | 13.00 (+6.67%) | 20.22 (64.29%) | 📈 view plot 🚷 view threshold | 116.00 (+1.32%) | 117.82 (98.46%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12.30 (+0.32%) | 12.51 (98.33%) | 📈 view plot 🚷 view threshold | 5.24 (-1.21%) | 5.43 (96.56%) | 📈 view plot 🚷 view threshold | 7.28 (-1.54%) | 7.60 (95.72%) | 📈 view plot 🚷 view threshold | 11.00 (+11.22%) | 18.42 (59.73%) | 📈 view plot 🚷 view threshold | 142.00 (+3.06%) | 142.43 (99.70%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24.70 (-0.06%) | 25.18 (98.07%) | 📈 view plot 🚷 view threshold | 9.79 (-0.80%) | 10.02 (97.70%) | 📈 view plot 🚷 view threshold | 13.79 (-0.98%) | 14.18 (97.23%) | 📈 view plot 🚷 view threshold | 33.00 (-7.29%) | 45.58 (72.41%) | 📈 view plot 🚷 view threshold | 307.00 (+1.26%) | 313.17 (98.03%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30.32 (-0.00%) | 30.72 (98.70%) | 📈 view plot 🚷 view threshold | 11.99 (-0.57%) | 12.19 (98.34%) | 📈 view plot 🚷 view threshold | 16.95 (-0.71%) | 17.30 (97.98%) | 📈 view plot 🚷 view threshold | 57.00 (+2.50%) | 66.98 (85.11%) | 📈 view plot 🚷 view threshold | 374.00 (+0.88%) | 379.31 (98.60%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126.48 (+0.02%) | 126.78 (99.76%) | 📈 view plot 🚷 view threshold | 73.12 (-0.19%) | 73.53 (99.44%) | 📈 view plot 🚷 view threshold | 104.76 (-0.24%) | 105.49 (99.31%) | 📈 view plot 🚷 view threshold | 109.00 (+2.78%) | 125.01 (87.19%) | 📈 view plot 🚷 view threshold | 605.00 (+1.28%) | 608.21 (99.47%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27.92 (+0.05%) | 28.42 (98.25%) | 📈 view plot 🚷 view threshold | 9.58 (-0.62%) | 9.76 (98.14%) | 📈 view plot 🚷 view threshold | 13.52 (-0.77%) | 13.83 (97.72%) | 📈 view plot 🚷 view threshold | 66.00 (+2.84%) | 77.29 (85.39%) | 📈 view plot 🚷 view threshold | 402.00 (+0.78%) | 410.69 (97.88%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115.22 (-0.02%) | 115.71 (99.57%) | 📈 view plot 🚷 view threshold | 67.89 (-0.26%) | 68.41 (99.24%) | 📈 view plot 🚷 view threshold | 97.36 (-0.32%) | 98.28 (99.07%) | 📈 view plot 🚷 view threshold | 65.00 (+0.98%) | 85.52 (76.00%) | 📈 view plot 🚷 view threshold | 501.00 (+1.67%) | 501.92 (99.82%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23.30 (-0.07%) | 23.83 (97.77%) | 📈 view plot 🚷 view threshold | 8.13 (-0.76%) | 8.31 (97.77%) | 📈 view plot 🚷 view threshold | 11.42 (-0.94%) | 11.74 (97.29%) | 📈 view plot 🚷 view threshold | 38.00 (-1.30%) | 50.23 (75.65%) | 📈 view plot 🚷 view threshold | 334.00 (+0.81%) | 342.87 (97.41%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99.83 (+0.03%) | 100.13 (99.69%) | 📈 view plot 🚷 view threshold | 61.33 (-0.23%) | 61.73 (99.34%) | 📈 view plot 🚷 view threshold | 87.94 (-0.28%) | 88.64 (99.20%) | 📈 view plot 🚷 view threshold | 47.00 (-0.91%) | 65.78 (71.45%) | 📈 view plot 🚷 view threshold | 333.00 (+2.44%) | 335.72 (99.19%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11.48 (+0.68%) | 11.60 (98.93%) | 📈 view plot 🚷 view threshold | 4.11 (-1.36%) | 4.28 (95.97%) | 📈 view plot 🚷 view threshold | 5.69 (-1.79%) | 6.00 (94.85%) | 📈 view plot 🚷 view threshold | 17.00 (+26.07%) | 23.14 (73.47%) | 📈 view plot 🚷 view threshold | 163.00 (+2.95%) | 163.65 (99.60%) |
plebhash
requested changes
Dec 23, 2024
There was a problem hiding this comment.
hey @Georges760 thanks for this
let's try to merge this PR before releasing v1.2.0
bumping MAJOR makes total sense
however some of the PATCH bumps are redundant since they've already been covered via #1300 in preparation for the release v1.2.0, so it would be redundant to bump 2x before publishing the crates to crates.io
we should rebase the PR to avoid bumping PATCH 2x on crates that have already been bumped via #1300, namely:
roles_logic_sv2sv2_ffi
we should also squash a60cbcc for a cleaner commit history
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being dropped via stratum-mining#1315 - with_serde will be dropped soon - no point in publishing docs for code under prop_test
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being dropped via stratum-mining#1315 - with_serde will be dropped soon
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being dropped via stratum-mining#1315 - with_serde will be dropped soon
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being dropped via stratum-mining#1315 - with_serde will be dropped soon - no point in publishing docs for code under prop_test
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being dropped via stratum-mining#1315 - with_serde will be dropped soon - no point in publishing docs for code under prop_test
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being dropped via stratum-mining#1315 - with_serde will be dropped soon - it is sufficient to publish the docs with with_buffer_pool feature flag
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being deprecated via stratum-mining#1315 - with_serde will be deprecated soon - no point in publishing docs for code under prop_test
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being deprecated via stratum-mining#1315 - with_serde will be deprecated soon
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being deprecated via stratum-mining#1315 - with_serde will be deprecated soon
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being deprecated via stratum-mining#1315 - with_serde will be deprecated soon - no point in publishing docs for code under prop_test
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being deprecated via stratum-mining#1315 - with_serde will be deprecated soon - no point in publishing docs for code under prop_test or disable_nopanic
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Dec 23, 2024
publishing with all-features is overengineering: - no_std is being deprecated via stratum-mining#1315 - with_serde will be deprecated soon - it is sufficient to publish the docs with noise_sv2 and with_buffer_pool feature flags
…stribution_sv2`: remove the `no_std` feature and make them `#![no_std]` as they never use `std` anywhere. - bump their MAJOR version because of feature removal - bump the dependant crates PATCH version - updates docs
Georges760
force-pushed
the
subprotocols_no_std
branch
from
a60cbcc to
e7f152d
Compare
@plebhash done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage 19.29% 19.29%
=======================================
Files 164 164
Lines 10852 10852
=======================================
Hits 2094 2094
Misses 8758 8758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
plebhash
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common_messages_sv2job_declaration_sv2mining_sv2template_distribution_sv2: remove theno_stdfeature and make them#![no_std]as they never usestdanywhere.