chore: combine ci #1312
Open
chore: combine ci #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yaml, fmt.yaml, clippy-lint.yaml, and add general-check.yaml to combine all in one file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 19.29% 19.29%
=======================================
Files 164 164
Lines 10852 10852
=======================================
Hits 2094 2094
Misses 8758 8758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | feature/Ci_combine |
| Testbed | sv2 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| client_sv2_open_channel_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 92.00 (+22.12%) | 89.10 (103.25%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2.17 (+2.92%) | 2.23 (97.46%) | 📈 view plot 🚷 view threshold | 473.00 (-0.05%) | 488.92 (96.74%) | 📈 view plot 🚷 view threshold | 731.00 (-0.63%) | 757.94 (96.45%) | 📈 view plot 🚷 view threshold | 8.00 (+60.25%) | 12.01 (66.61%) | 📈 view plot 🚷 view threshold | 40.00 (+3.79%) | 41.57 (96.23%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8.29 (+0.82%) | 8.38 (98.86%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.01%) | 2,140.48 (99.84%) | 📈 view plot 🚷 view threshold | 3,153.00 (-0.20%) | 3,169.23 (99.49%) | 📈 view plot 🚷 view threshold | 40.00 (+12.55%) | 41.79 (95.72%) | 📈 view plot 🚷 view threshold | 141.00 (+1.05%) | 144.04 (97.89%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6.36 (+1.00%) | 6.44 (98.73%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.02%) | 1,766.19 (99.08%) | 📈 view plot 🚷 view threshold | 2,546.00 (-0.23%) | 2,574.61 (98.89%) | 📈 view plot 🚷 view threshold | 21.00 (+22.91%) | 24.31 (86.40%) | 📈 view plot 🚷 view threshold | 106.00 (+1.34%) | 108.61 (97.60%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14.76 (+0.25%) | 14.93 (98.85%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.01%) | 4,710.19 (99.66%) | 📈 view plot 🚷 view threshold | 6,745.00 (-0.17%) | 6,785.77 (99.40%) | 📈 view plot 🚷 view threshold | 56.00 (+24.68%) | 61.03 (91.75%) | 📈 view plot 🚷 view threshold | 221.00 (-0.09%) | 226.35 (97.63%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27.78 (+0.71%) | 28.00 (99.20%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.40%) | 10,686.96 (99.61%) | 📈 view plot 🚷 view threshold | 15,498.00 (+0.43%) | 15,574.54 (99.51%) | 📈 view plot 🚷 view threshold | 97.00 (+16.64%) | 98.17 (98.81%) | 📈 view plot 🚷 view threshold | 337.00 (+0.51%) | 342.41 (98.42%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4.49 (+2.18%) | 4.56 (98.53%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.02%) | 1,476.92 (98.92%) | 📈 view plot 🚷 view threshold | 2,154.00 (-0.30%) | 2,183.67 (98.64%) | 📈 view plot 🚷 view threshold | 12.00 (+48.12%) | 13.64 (88.00%) | 📈 view plot 🚷 view threshold | 65.00 (+3.78%) | 67.15 (96.80%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14.05 (+0.22%) | 14.19 (98.99%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.00%) | 5,079.92 (99.69%) | 📈 view plot 🚷 view threshold | 7,318.00 (-0.11%) | 7,351.41 (99.55%) | 📈 view plot 🚷 view threshold | 44.00 (+22.20%) | 47.20 (93.21%) | 📈 view plot 🚷 view threshold | 186.00 (-0.02%) | 190.97 (97.40%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22.92 (+1.02%) | 23.01 (99.62%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.11%) | 8,053.90 (99.83%) | 📈 view plot 🚷 view threshold | 11,680.00 (-0.03%) | 11,711.07 (99.73%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 92.00 (+22.12%) | 89.10 (103.25%) | 📈 view plot 🚷 view threshold | 308.00 (+1.43%) | 311.21 (98.97%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4.75 (+1.39%) | 4.79 (99.29%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.02%) | 1,517.92 (98.95%) | 📈 view plot 🚷 view threshold | 2,273.00 (-0.23%) | 2,299.55 (98.85%) | 📈 view plot 🚷 view threshold | 13.00 (+37.41%) | 15.61 (83.29%) | 📈 view plot 🚷 view threshold | 69.00 (+2.22%) | 70.06 (98.49%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16.26 (+0.66%) | 16.31 (99.67%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.00%) | 5,978.92 (99.73%) | 📈 view plot 🚷 view threshold | 8,651.00 (-0.15%) | 8,691.68 (99.53%) | 📈 view plot 🚷 view threshold | 51.00 (+27.43%) | 54.35 (93.84%) | 📈 view plot 🚷 view threshold | 210.00 (+0.88%) | 211.94 (99.08%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35.77 (+0.52%) | 35.90 (99.64%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.16%) | 14,912.40 (99.84%) | 📈 view plot 🚷 view threshold | 21,862.00 (+0.10%) | 21,910.66 (99.78%) | 📈 view plot 🚷 view threshold | 115.00 (+23.32%) | 116.92 (98.35%) | 📈 view plot 🚷 view threshold | 381.00 (+0.42%) | 385.08 (98.94%) |
|
| Branch | feature/Ci_combine |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary 1e3 x instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary 1e3 x accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8.45 (-0.07%) | 8.67 (97.39%) | 📈 view plot 🚷 view threshold | 3.66 (-1.84%) | 3.86 (94.85%) | 📈 view plot 🚷 view threshold | 5.11 (-2.25%) | 5.45 (93.79%) | 📈 view plot 🚷 view threshold | 10.00 (+23.31%) | 15.60 (64.12%) | 📈 view plot 🚷 view threshold | 94.00 (+3.19%) | 96.07 (97.84%) |
| get_submit | 📈 view plot 🚷 view threshold | 95.37 (+0.00%) | 95.68 (99.68%) | 📈 view plot 🚷 view threshold | 59.26 (-0.26%) | 59.71 (99.26%) | 📈 view plot 🚷 view threshold | 85.07 (-0.31%) | 85.82 (99.13%) | 📈 view plot 🚷 view threshold | 51.00 (+14.93%) | 59.91 (85.12%) | 📈 view plot 🚷 view threshold | 287.00 (+2.36%) | 290.37 (98.84%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7.96 (-0.51%) | 8.23 (96.67%) | 📈 view plot 🚷 view threshold | 2.76 (-2.16%) | 2.94 (93.70%) | 📈 view plot 🚷 view threshold | 3.83 (-2.62%) | 4.14 (92.46%) | 📈 view plot 🚷 view threshold | 14.00 (+14.80%) | 20.24 (69.17%) | 📈 view plot 🚷 view threshold | 116.00 (+1.32%) | 117.82 (98.46%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12.23 (-0.23%) | 12.51 (97.79%) | 📈 view plot 🚷 view threshold | 5.24 (-1.21%) | 5.43 (96.56%) | 📈 view plot 🚷 view threshold | 7.28 (-1.51%) | 7.60 (95.74%) | 📈 view plot 🚷 view threshold | 11.00 (+11.22%) | 18.42 (59.73%) | 📈 view plot 🚷 view threshold | 140.00 (+1.62%) | 142.31 (98.38%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24.66 (-0.20%) | 25.18 (97.94%) | 📈 view plot 🚷 view threshold | 9.79 (-0.80%) | 10.02 (97.70%) | 📈 view plot 🚷 view threshold | 13.79 (-0.97%) | 14.18 (97.23%) | 📈 view plot 🚷 view threshold | 33.00 (-7.29%) | 45.58 (72.41%) | 📈 view plot 🚷 view threshold | 306.00 (+0.94%) | 313.13 (97.72%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30.25 (-0.26%) | 30.72 (98.44%) | 📈 view plot 🚷 view threshold | 11.99 (-0.57%) | 12.19 (98.34%) | 📈 view plot 🚷 view threshold | 16.95 (-0.68%) | 17.30 (98.01%) | 📈 view plot 🚷 view threshold | 54.00 (-2.85%) | 66.95 (80.65%) | 📈 view plot 🚷 view threshold | 372.00 (+0.34%) | 379.25 (98.09%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126.43 (-0.02%) | 126.78 (99.72%) | 📈 view plot 🚷 view threshold | 73.12 (-0.19%) | 73.53 (99.44%) | 📈 view plot 🚷 view threshold | 104.75 (-0.25%) | 105.49 (99.30%) | 📈 view plot 🚷 view threshold | 121.00 (+13.99%) | 125.54 (96.39%) | 📈 view plot 🚷 view threshold | 602.00 (+0.78%) | 608.05 (99.00%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27.86 (-0.15%) | 28.42 (98.06%) | 📈 view plot 🚷 view threshold | 9.58 (-0.62%) | 9.76 (98.14%) | 📈 view plot 🚷 view threshold | 13.52 (-0.78%) | 13.83 (97.71%) | 📈 view plot 🚷 view threshold | 69.00 (+7.47%) | 77.38 (89.17%) | 📈 view plot 🚷 view threshold | 400.00 (+0.28%) | 410.65 (97.41%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115.19 (-0.05%) | 115.71 (99.54%) | 📈 view plot 🚷 view threshold | 67.89 (-0.26%) | 68.41 (99.24%) | 📈 view plot 🚷 view threshold | 97.36 (-0.33%) | 98.28 (99.06%) | 📈 view plot 🚷 view threshold | 73.00 (+13.30%) | 85.72 (85.16%) | 📈 view plot 🚷 view threshold | 499.00 (+1.27%) | 501.78 (99.45%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23.27 (-0.20%) | 23.83 (97.65%) | 📈 view plot 🚷 view threshold | 8.13 (-0.76%) | 8.31 (97.77%) | 📈 view plot 🚷 view threshold | 11.42 (-0.94%) | 11.74 (97.29%) | 📈 view plot 🚷 view threshold | 39.00 (+1.28%) | 50.24 (77.63%) | 📈 view plot 🚷 view threshold | 333.00 (+0.51%) | 342.84 (97.13%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99.83 (+0.03%) | 100.13 (99.69%) | 📈 view plot 🚷 view threshold | 61.33 (-0.23%) | 61.73 (99.34%) | 📈 view plot 🚷 view threshold | 87.93 (-0.29%) | 88.64 (99.19%) | 📈 view plot 🚷 view threshold | 56.00 (+17.89%) | 66.00 (84.85%) | 📈 view plot 🚷 view threshold | 332.00 (+2.13%) | 335.66 (98.91%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11.44 (+0.34%) | 11.60 (98.61%) | 📈 view plot 🚷 view threshold | 4.11 (-1.36%) | 4.28 (95.97%) | 📈 view plot 🚷 view threshold | 5.69 (-1.76%) | 6.00 (94.88%) | 📈 view plot 🚷 view threshold | 16.00 (+18.72%) | 23.11 (69.25%) | 📈 view plot 🚷 view threshold | 162.00 (+2.32%) | 163.58 (99.04%) |
|
| Branch | feature/Ci_combine |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,437.00 (-2.25%) | 6,919.57 (93.03%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,337.10 (-1.29%) | 7,835.54 (93.64%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 7,977.30 (-1.60%) | 9,274.74 (86.01%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 901.34 (+3.87%) | 945.32 (95.35%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 667.07 (-1.02%) | 715.45 (93.24%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 250.01 (+0.34%) | 270.00 (92.60%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 156.35 (-0.68%) | 166.27 (94.03%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,255.70 (-1.71%) | 6,749.35 (92.69%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 286.37 (+1.45%) | 323.98 (88.39%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 745.33 (+2.46%) | 776.67 (95.97%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 596.82 (+1.21%) | 626.06 (95.33%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 212.63 (+2.90%) | 224.71 (94.62%) |
jbesraa
suggested changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks for looking into this. i'am yet to give it a thorough review but can you please fix ci https://github.com/stratum-mining/stratum/actions/runs/12425379179/workflow ?
sure, i do it as a syntax test and forgot to fix |
|
you think that we can set some pattern to the jobs names? i made just a "draft" to bring to table |
jbesraa
suggested changes
Dec 23, 2024
There was a problem hiding this comment.
Is there anyway to make this shorter?
Can we try to avoid repeating this following part?
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- macos-latest
- ubuntu-latest
include:
- os: macos-latest
target: x86_64-apple-darwin
- os: ubuntu-latest
target: x86_64-unknown-linux-musl
steps:
- uses: actions/checkout@v4
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.75.0
override: true
components: clippy
jbesraa
suggested changes
Dec 24, 2024
There was a problem hiding this comment.
This is going in the right direction but currently it does not seem to be fully working https://github.com/stratum-mining/stratum/actions/runs/12472789699/workflow
|
You can take some inspiration from here https://github.com/lightningdevkit/rust-lightning/tree/main/ci If you feel the need to move things to a shell script and just invoke it in the GH action. I think that would be also great for local dev env where devs can just call the shell script to replicate the GH action flow. Edit: Maybe this is a bit too much for this PR and can happen in a subsequent one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, as required try to combine all asked yamls in only one yaml to ci/cd separated by jobs.
Issue: #1272