Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump TP to 0.1.13 for CI #1310

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Bump TP to 0.1.13 for CI #1310

merged 3 commits into from
Dec 19, 2024

Conversation

Sjors
Copy link
Collaborator

@Sjors Sjors commented Dec 19, 2024

It's had enough manual testing that I feel good about this release. Let's make sure there's breaking changes I missed though.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.04%. Comparing base (fd1b488) to head (c4bd2bb).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   19.29%   17.04%   -2.26%     
==========================================
  Files         164      162       -2     
  Lines       10852    10761      -91     
==========================================
- Hits         2094     1834     -260     
- Misses       8758     8927     +169
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage ?
buffer_sv2-coverage ?
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage ?
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils ?
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024/12/bump-tp
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.83
(-0.78%)		58.56
(76.55%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		73.08
(-6.16%)		104.30
(70.07%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.69
(+0.18%)		14.72
(99.80%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		280.06
(+4.78%)		292.26
(95.82%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		618.12
(+0.80%)		649.72
(95.14%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.93
(-0.54%)		175.98
(93.15%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		285.47
(-0.04%)		309.96
(92.10%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		379.99
(-1.00%)		408.72
(92.97%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		164.15
(+2.46%)		171.69
(95.61%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		473.20
(+0.23%)		550.72
(85.92%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		996.56
(-0.25%)		1,142.15
(87.25%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024/12/bump-tp
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,455.30
(-2.11%)		6,952.44
(92.85%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,373.30
(-1.03%)		7,885.96
(93.50%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,996.20
(-1.51%)		9,295.47
(86.02%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		859.63
(-0.71%)		939.11
(91.54%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		675.42
(+0.29%)		713.73
(94.63%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		251.13
(+0.79%)		270.07
(92.99%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		159.29
(+1.12%)		166.45
(95.70%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,211.80
(-2.60%)		6,852.41
(90.65%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		281.29
(-0.37%)		324.29
(86.74%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		723.74
(-0.38%)		773.73
(93.54%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		595.19
(+1.01%)		623.53
(95.46%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		203.85
(-1.23%)		223.81
(91.08%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024/12/bump-tp
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,319.00
(-1.60%)		8,678.38
(95.86%)		📈 view plot
🚷 view threshold		3,689.00
(-1.16%)		3,861.73
(95.53%)		📈 view plot
🚷 view threshold		5,159.00
(-1.30%)		5,446.24
(94.73%)		📈 view plot
🚷 view threshold		9.00
(+11.41%)		15.54
(57.92%)		📈 view plot
🚷 view threshold		89.00
(-2.26%)		96.02
(92.69%)
get_submit📈 view plot
🚷 view threshold		95,167.00
(-0.21%)		95,695.71
(99.45%)		📈 view plot
🚷 view threshold		59,346.00
(-0.12%)		59,707.30
(99.39%)		📈 view plot
🚷 view threshold		85,222.00
(-0.14%)		85,817.60
(99.31%)		📈 view plot
🚷 view threshold		50.00
(+12.74%)		59.79
(83.62%)		📈 view plot
🚷 view threshold		277.00
(-1.19%)		290.29
(95.42%)
get_subscribe📈 view plot
🚷 view threshold		7,812.00
(-2.38%)		8,240.25
(94.80%)		📈 view plot
🚷 view threshold		2,765.00
(-1.93%)		2,943.26
(93.94%)		📈 view plot
🚷 view threshold		3,847.00
(-2.24%)		4,143.03
(92.85%)		📈 view plot
🚷 view threshold		16.00
(+31.45%)		20.21
(79.17%)		📈 view plot
🚷 view threshold		111.00
(-3.04%)		117.91
(94.14%)
serialize_authorize📈 view plot
🚷 view threshold		12,036.00
(-1.84%)		12,517.06
(96.16%)		📈 view plot
🚷 view threshold		5,266.00
(-0.74%)		5,426.41
(97.04%)		📈 view plot
🚷 view threshold		7,331.00
(-0.82%)		7,601.37
(96.44%)		📈 view plot
🚷 view threshold		10.00
(+1.35%)		18.37
(54.44%)		📈 view plot
🚷 view threshold		133.00
(-3.45%)		142.42
(93.39%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,526.00
(-0.75%)		25,182.33
(97.39%)		📈 view plot
🚷 view threshold		9,838.00
(-0.29%)		10,017.96
(98.20%)		📈 view plot
🚷 view threshold		13,881.00
(-0.31%)		14,180.90
(97.89%)		📈 view plot
🚷 view threshold		36.00
(+1.16%)		45.50
(79.12%)		📈 view plot
🚷 view threshold		299.00
(-1.35%)		313.15
(95.48%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,046.00
(-0.92%)		30,725.02
(97.79%)		📈 view plot
🚷 view threshold		12,015.00
(-0.36%)		12,192.20
(98.55%)		📈 view plot
🚷 view threshold		17,001.00
(-0.42%)		17,299.60
(98.27%)		📈 view plot
🚷 view threshold		61.00
(+9.62%)		67.11
(90.89%)		📈 view plot
🚷 view threshold		364.00
(-1.80%)		379.32
(95.96%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,231.00
(-0.18%)		126,784.60
(99.56%)		📈 view plot
🚷 view threshold		73,200.00
(-0.08%)		73,524.69
(99.56%)		📈 view plot
🚷 view threshold		104,911.00
(-0.10%)		105,489.83
(99.45%)		📈 view plot
🚷 view threshold		113.00
(+6.56%)		124.97
(90.42%)		📈 view plot
🚷 view threshold		593.00
(-0.72%)		607.93
(97.54%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,654.00
(-0.90%)		28,419.97
(97.30%)		📈 view plot
🚷 view threshold		9,584.00
(-0.55%)		9,758.14
(98.22%)		📈 view plot
🚷 view threshold		13,534.00
(-0.67%)		13,833.88
(97.83%)		📈 view plot
🚷 view threshold		73.00
(+13.70%)		77.49
(94.20%)		📈 view plot
🚷 view threshold		393.00
(-1.45%)		410.85
(95.66%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,153.00
(-0.08%)		115,716.30
(99.51%)		📈 view plot
🚷 view threshold		68,060.00
(-0.02%)		68,413.62
(99.48%)		📈 view plot
🚷 view threshold		97,648.00
(-0.03%)		98,274.36
(99.36%)		📈 view plot
🚷 view threshold		71.00
(+10.37%)		85.40
(83.14%)		📈 view plot
🚷 view threshold		490.00
(-0.55%)		501.55
(97.70%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,078.00
(-1.03%)		23,838.40
(96.81%)		📈 view plot
🚷 view threshold		8,143.00
(-0.60%)		8,314.15
(97.94%)		📈 view plot
🚷 view threshold		11,453.00
(-0.69%)		11,741.77
(97.54%)		📈 view plot
🚷 view threshold		43.00
(+11.73%)		50.14
(85.76%)		📈 view plot
🚷 view threshold		326.00
(-1.58%)		342.98
(95.05%)
serialize_submit📈 view plot
🚷 view threshold		99,548.00
(-0.25%)		100,151.77
(99.40%)		📈 view plot
🚷 view threshold		61,408.00
(-0.10%)		61,733.76
(99.47%)		📈 view plot
🚷 view threshold		88,083.00
(-0.12%)		88,644.82
(99.37%)		📈 view plot
🚷 view threshold		53.00
(+11.78%)		65.71
(80.66%)		📈 view plot
🚷 view threshold		320.00
(-1.55%)		335.60
(95.35%)
serialize_subscribe📈 view plot
🚷 view threshold		11,257.00
(-1.26%)		11,607.41
(96.98%)		📈 view plot
🚷 view threshold		4,118.00
(-1.21%)		4,283.51
(96.14%)		📈 view plot
🚷 view threshold		5,707.00
(-1.48%)		5,996.31
(95.18%)		📈 view plot
🚷 view threshold		18.00
(+33.80%)		23.06
(78.07%)		📈 view plot
🚷 view threshold		156.00
(-1.46%)		163.55
(95.39%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024/12/bump-tp
Testbedsv2

🚨 4 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_mining_message_submit_standardL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		25.00
(+46.12%)		24.56
(101.77%)
client_sv2_open_channelL2 Accesses
accesses		📈 plot
🚨 alert (🔕)
🚷 threshold		15.00
(+84.08%)		14.00
(107.14%)
client_sv2_open_channel_serializeL2 Accesses
accesses		📈 plot
🚨 alert (🔕)
🚷 threshold		49.00
(+36.11%)		47.55
(103.04%)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		91.00
(+20.91%)		88.77
(102.51%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,115.00
(+0.29%)		2,225.39
(95.04%)		📈 view plot
🚷 view threshold		473.00
(-0.05%)		488.92
(96.74%)		📈 view plot
🚷 view threshold		730.00
(-0.76%)		757.95
(96.31%)		📈 view plot
🚷 view threshold		11.00
(+118.63%)		12.26
(89.71%)		📈 view plot
🚷 view threshold		38.00
(-1.34%)		41.52
(91.52%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,284.00
(+0.78%)		8,382.21
(98.83%)		📈 view plot
🚷 view threshold		2,137.00
(-0.01%)		2,140.90
(99.82%)		📈 view plot
🚷 view threshold		3,154.00
(-0.17%)		3,169.54
(99.51%)		📈 view plot
🚷 view threshold		39.00
(+9.81%)		41.70
(93.52%)		📈 view plot
🚷 view threshold		141.00
(+1.06%)		144.02
(97.90%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,275.00
(-0.35%)		6,441.00
(97.42%)		📈 view plot
🚷 view threshold		1,750.00
(-0.03%)		1,766.31
(99.08%)		📈 view plot
🚷 view threshold		2,545.00
(-0.27%)		2,574.78
(98.84%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		25.00
(+46.12%)		24.56
(101.77%)		📈 view plot
🚷 view threshold		103.00
(-1.50%)		108.59
(94.85%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,738.00
(+0.10%)		14,934.40
(98.68%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,710.31
(99.65%)		📈 view plot
🚷 view threshold		6,743.00
(-0.20%)		6,785.86
(99.37%)		📈 view plot
🚷 view threshold		59.00
(+31.45%)		61.03
(96.67%)		📈 view plot
🚷 view threshold		220.00
(-0.55%)		226.44
(97.16%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,744.00
(+0.59%)		27,998.16
(99.09%)		📈 view plot
🚷 view threshold		10,645.00
(+0.41%)		10,685.75
(99.62%)		📈 view plot
🚷 view threshold		15,499.00
(+0.44%)		15,572.49
(99.53%)		📈 view plot
🚷 view threshold		97.00
(+16.75%)		98.00
(98.98%)		📈 view plot
🚷 view threshold		336.00
(+0.22%)		342.39
(98.13%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,433.00
(+0.94%)		4,551.18
(97.40%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,476.92
(98.92%)		📈 view plot
🚷 view threshold		2,153.00
(-0.34%)		2,183.69
(98.59%)		📈 view plot
🚨 view alert (🔕)
🚷 view threshold		15.00
(+84.08%)		14.00
(107.14%)		📈 view plot
🚷 view threshold		63.00
(+0.66%)		67.02
(94.00%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,034.00
(+0.12%)		14,192.08
(98.89%)		📈 view plot
🚷 view threshold		5,064.00
(-0.00%)		5,079.92
(99.69%)		📈 view plot
🚷 view threshold		7,314.00
(-0.17%)		7,351.51
(99.49%)		📈 view plot
🚨 view alert (🔕)
🚷 view threshold		49.00
(+36.11%)		47.55
(103.04%)		📈 view plot
🚷 view threshold		185.00
(-0.55%)		191.00
(96.86%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,882.00
(+0.86%)		22,997.90
(99.50%)		📈 view plot
🚷 view threshold		8,040.00
(+0.11%)		8,053.68
(99.83%)		📈 view plot
🚷 view threshold		11,682.00
(-0.01%)		11,710.98
(99.75%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		91.00
(+20.91%)		88.77
(102.51%)		📈 view plot
🚷 view threshold		307.00
(+1.11%)		311.03
(98.70%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,693.00
(+0.12%)		4,784.66
(98.08%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.92
(98.95%)		📈 view plot
🚷 view threshold		2,273.00
(-0.23%)		2,299.54
(98.85%)		📈 view plot
🚷 view threshold		15.00
(+57.76%)		15.84
(94.68%)		📈 view plot
🚷 view threshold		67.00
(-0.71%)		70.00
(95.71%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,158.00
(+0.06%)		16,306.31
(99.09%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.92
(99.73%)		📈 view plot
🚷 view threshold		8,653.00
(-0.13%)		8,691.64
(99.56%)		📈 view plot
🚷 view threshold		52.00
(+29.82%)		54.53
(95.36%)		📈 view plot
🚷 view threshold		207.00
(-0.54%)		211.88
(97.70%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,704.00
(+0.34%)		35,895.81
(99.47%)		📈 view plot
🚷 view threshold		14,888.00
(+0.16%)		14,911.76
(99.84%)		📈 view plot
🚷 view threshold		21,864.00
(+0.11%)		21,910.04
(99.79%)		📈 view plot
🚷 view threshold		115.00
(+23.49%)		116.38
(98.81%)		📈 view plot
🚷 view threshold		379.00
(-0.11%)		385.04
(98.43%)
🐰 View full continuous benchmarking report in Bencher

@jbesraa
Copy link
Contributor

jbesraa commented Dec 19, 2024

Integration tests seems to fail here https://github.com/stratum-mining/stratum/blob/main/roles/tests-integration/tests/pool_integration.rs#L58
Anything changed with what messages are exchanged when connecting TP to a Pool?

@Sjors
Copy link
Collaborator Author

Sjors commented Dec 19, 2024 •
edited
Loading

The pool_integration test fails mysteriously here:

assert_tp_message!(&sniffer.next_message_from_upstream(), NewTemplate);

Looking at the Bitcoin Core log the message does arrive.

It does take a bit longer, about little under half a second. So I tried adding:

std::thread::sleep(std::time::Duration::from_millis(1000));

But that didn't help. I can reproduce the issue locally as well.

Any ideas?

cc @jbesraa

Afaik the only difference between these versions is a slight delay between CoinbaseOutputDataSize and the first NewTemplate.

@jbesraa
Copy link
Contributor

jbesraa commented Dec 19, 2024

Here is a fix:
f332727

Instead of checking immediately for NewTemplate message, we wait for it to arrive first

@Sjors
Copy link
Collaborator Author

Sjors commented Dec 19, 2024

@jbesraa thanks! I took your fix.

Also improved the TP logging a bit in the tests.

jbesraa and others added 3 commits December 19, 2024 18:42
@plebhash plebhash merged commit e8d76d6 into stratum-mining:main Dec 19, 2024
37 checks passed
@Sjors Sjors deleted the 2024/12/bump-tp branch December 20, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash approved these changes

@jbesraa jbesraa jbesraa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sjors @jbesraa @plebhash