Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codecov.yml to remove ci error #1308

Merged
merged 1 commit into from
Dec 18, 2024
Merged

add codecov.yml to remove ci error #1308

merged 1 commit into from
Dec 18, 2024

Conversation

Shourya742
Copy link
Contributor

This PR introduces a codecov.yml file that sets thresholds for both patches and the overall project. With this, the CI issues related to threshold violations are resolved.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-codecov-ci-error
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.27
(-1.92%)		58.88
(75.19%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		76.28
(-2.55%)		104.43
(73.04%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(+0.06%)		14.71
(99.72%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		263.79
(-0.96%)		293.62
(89.84%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		618.72
(+0.97%)		647.06
(95.62%)
client_sv2_open_channel📈 view plot
🚷 view threshold		164.89
(-0.05%)		176.13
(93.62%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		279.21
(-2.03%)		309.73
(90.15%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		388.39
(+1.12%)		409.92
(94.75%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		166.66
(+3.99%)		172.10
(96.84%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		493.56
(+4.44%)		553.41
(89.19%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		986.30
(-1.09%)		1,143.77
(86.23%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-codecov-ci-error
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,517.20
(-1.46%)		7,009.91
(92.97%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,358.10
(-1.43%)		7,943.06
(92.64%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,915.50
(-2.60%)		9,331.96
(84.82%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		868.90
(+0.35%)		940.45
(92.39%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		670.27
(-0.36%)		713.82
(93.90%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		251.79
(+0.99%)		270.93
(92.94%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		157.64
(+0.12%)		166.46
(94.70%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,299.40
(-1.50%)		6,915.53
(91.09%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		278.13
(-1.53%)		325.61
(85.42%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		722.55
(-0.57%)		776.14
(93.10%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		592.07
(+0.74%)		617.84
(95.83%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		208.39
(+0.94%)		223.63
(93.18%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (367c55a) to head (6bc58b0).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1308   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         164      164           
  Lines       10852    10852           
=======================================
  Hits         2094     2094           
  Misses       8758     8758
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-codecov-ci-error
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,421.00
(-0.42%)		8,676.71
(97.05%)		📈 view plot
🚷 view threshold		3,689.00
(-1.20%)		3,862.77
(95.50%)		📈 view plot
🚷 view threshold		5,156.00
(-1.40%)		5,448.38
(94.63%)		📈 view plot
🚷 view threshold		9.00
(+12.50%)		15.52
(58.01%)		📈 view plot
🚷 view threshold		92.00
(+1.01%)		96.01
(95.82%)
get_submit📈 view plot
🚷 view threshold		95,269.00
(-0.12%)		95,713.92
(99.54%)		📈 view plot
🚷 view threshold		59,346.00
(-0.13%)		59,711.26
(99.39%)		📈 view plot
🚷 view threshold		85,219.00
(-0.14%)		85,823.87
(99.30%)		📈 view plot
🚷 view threshold		50.00
(+12.89%)		59.54
(83.97%)		📈 view plot
🚷 view threshold		280.00
(-0.16%)		290.40
(96.42%)
get_subscribe📈 view plot
🚷 view threshold		7,910.00
(-1.20%)		8,234.23
(96.06%)		📈 view plot
🚷 view threshold		2,765.00
(-1.98%)		2,943.12
(93.95%)		📈 view plot
🚷 view threshold		3,845.00
(-2.35%)		4,143.08
(92.81%)		📈 view plot
🚷 view threshold		15.00
(+24.35%)		19.99
(75.04%)		📈 view plot
🚷 view threshold		114.00
(-0.46%)		117.78
(96.79%)
serialize_authorize📈 view plot
🚷 view threshold		12,142.00
(-1.02%)		12,510.17
(97.06%)		📈 view plot
🚷 view threshold		5,266.00
(-0.76%)		5,427.49
(97.02%)		📈 view plot
🚷 view threshold		7,327.00
(-0.90%)		7,603.54
(96.36%)		📈 view plot
🚷 view threshold		11.00
(+12.19%)		18.36
(59.92%)		📈 view plot
🚷 view threshold		136.00
(-1.33%)		142.21
(95.64%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,666.00
(-0.18%)		25,180.87
(97.96%)		📈 view plot
🚷 view threshold		9,838.00
(-0.31%)		10,022.74
(98.16%)		📈 view plot
🚷 view threshold		13,876.00
(-0.37%)		14,187.72
(97.80%)		📈 view plot
🚷 view threshold		37.00
(+4.36%)		45.45
(81.41%)		📈 view plot
🚷 view threshold		303.00
(-0.02%)		313.27
(96.72%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,140.00
(-0.62%)		30,714.54
(98.13%)		📈 view plot
🚷 view threshold		12,015.00
(-0.38%)		12,195.41
(98.52%)		📈 view plot
🚷 view threshold		17,000.00
(-0.44%)		17,303.63
(98.25%)		📈 view plot
🚷 view threshold		59.00
(+6.11%)		67.02
(88.03%)		📈 view plot
🚷 view threshold		367.00
(-1.00%)		379.23
(96.77%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,257.00
(-0.16%)		126,780.45
(99.59%)		📈 view plot
🚷 view threshold		73,200.00
(-0.09%)		73,525.82
(99.56%)		📈 view plot
🚷 view threshold		104,912.00
(-0.11%)		105,491.61
(99.45%)		📈 view plot
🚷 view threshold		111.00
(+4.78%)		124.63
(89.06%)		📈 view plot
🚷 view threshold		594.00
(-0.57%)		607.88
(97.72%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,778.00
(-0.45%)		28,427.39
(97.72%)		📈 view plot
🚷 view threshold		9,584.00
(-0.56%)		9,757.40
(98.22%)		📈 view plot
🚷 view threshold		13,533.00
(-0.69%)		13,832.86
(97.83%)		📈 view plot
🚷 view threshold		70.00
(+9.31%)		77.03
(90.87%)		📈 view plot
🚷 view threshold		397.00
(-0.43%)		411.25
(96.53%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,183.00
(-0.05%)		115,720.59
(99.54%)		📈 view plot
🚷 view threshold		68,060.00
(-0.02%)		68,417.24
(99.48%)		📈 view plot
🚷 view threshold		97,648.00
(-0.03%)		98,280.83
(99.36%)		📈 view plot
🚷 view threshold		70.00
(+9.19%)		84.90
(82.45%)		📈 view plot
🚷 view threshold		491.00
(-0.35%)		501.52
(97.90%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,218.00
(-0.42%)		23,843.04
(97.38%)		📈 view plot
🚷 view threshold		8,143.00
(-0.61%)		8,313.77
(97.95%)		📈 view plot
🚷 view threshold		11,448.00
(-0.75%)		11,741.33
(97.50%)		📈 view plot
🚷 view threshold		44.00
(+14.82%)		49.70
(88.54%)		📈 view plot
🚷 view threshold		330.00
(-0.35%)		343.28
(96.13%)
serialize_submit📈 view plot
🚷 view threshold		99,650.00
(-0.16%)		100,163.02
(99.49%)		📈 view plot
🚷 view threshold		61,408.00
(-0.10%)		61,737.73
(99.47%)		📈 view plot
🚷 view threshold		88,080.00
(-0.12%)		88,651.50
(99.36%)		📈 view plot
🚷 view threshold		53.00
(+12.15%)		65.41
(81.03%)		📈 view plot
🚷 view threshold		323.00
(-0.67%)		335.66
(96.23%)
serialize_subscribe📈 view plot
🚷 view threshold		11,355.00
(-0.43%)		11,607.14
(97.83%)		📈 view plot
🚷 view threshold		4,118.00
(-1.24%)		4,283.41
(96.14%)		📈 view plot
🚷 view threshold		5,705.00
(-1.55%)		5,996.24
(95.14%)		📈 view plot
🚷 view threshold		17.00
(+27.40%)		22.77
(74.65%)		📈 view plot
🚷 view threshold		159.00
(+0.41%)		163.58
(97.20%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-codecov-ci-error
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,163.00
(+2.57%)		2,226.05
(97.17%)		📈 view plot
🚷 view threshold		473.00
(-0.05%)		488.96
(96.74%)		📈 view plot
🚷 view threshold		733.00
(-0.35%)		758.00
(96.70%)		📈 view plot
🚷 view threshold		6.00
(+17.97%)		12.76
(47.04%)		📈 view plot
🚷 view threshold		40.00
(+3.88%)		41.56
(96.24%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,314.00
(+1.15%)		8,381.11
(99.20%)		📈 view plot
🚷 view threshold		2,137.00
(-0.02%)		2,141.63
(99.78%)		📈 view plot
🚷 view threshold		3,154.00
(-0.17%)		3,169.99
(99.50%)		📈 view plot
🚷 view threshold		38.00
(+6.97%)		41.73
(91.05%)		📈 view plot
🚷 view threshold		142.00
(+1.79%)		143.97
(98.63%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,391.00
(+1.48%)		6,443.14
(99.19%)		📈 view plot
🚷 view threshold		1,750.00
(-0.03%)		1,766.68
(99.06%)		📈 view plot
🚷 view threshold		2,546.00
(-0.24%)		2,575.10
(98.87%)		📈 view plot
🚷 view threshold		20.00
(+17.00%)		24.48
(81.71%)		📈 view plot
🚷 view threshold		107.00
(+2.31%)		108.62
(98.51%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,846.00
(+0.83%)		14,939.40
(99.37%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,710.68
(99.65%)		📈 view plot
🚷 view threshold		6,746.00
(-0.16%)		6,785.90
(99.41%)		📈 view plot
🚷 view threshold		52.00
(+16.20%)		60.30
(86.23%)		📈 view plot
🚷 view threshold		224.00
(+1.24%)		226.57
(98.87%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,846.00
(+0.97%)		27,993.18
(99.47%)		📈 view plot
🚷 view threshold		10,645.00
(+0.41%)		10,683.23
(99.64%)		📈 view plot
🚷 view threshold		15,496.00
(+0.43%)		15,568.22
(99.54%)		📈 view plot
🚷 view threshold		97.00
(+16.96%)		97.47
(99.52%)		📈 view plot
🚷 view threshold		339.00
(+1.11%)		342.43
(99.00%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,477.00
(+1.98%)		4,549.94
(98.40%)		📈 view plot
🚷 view threshold		1,461.00
(-0.02%)		1,476.96
(98.92%)		📈 view plot
🚷 view threshold		2,157.00
(-0.16%)		2,183.65
(98.78%)		📈 view plot
🚷 view threshold		9.00
(+10.24%)		14.01
(64.23%)		📈 view plot
🚷 view threshold		65.00
(+3.94%)		67.03
(96.96%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,066.00
(+0.34%)		14,193.80
(99.10%)		📈 view plot
🚷 view threshold		5,064.00
(-0.00%)		5,079.96
(99.69%)		📈 view plot
🚷 view threshold		7,321.00
(-0.07%)		7,351.39
(99.59%)		📈 view plot
🚷 view threshold		40.00
(+11.55%)		46.76
(85.54%)		📈 view plot
🚷 view threshold		187.00
(+0.50%)		191.06
(97.87%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,866.00
(+0.81%)		22,987.25
(99.47%)		📈 view plot
🚷 view threshold		8,040.00
(+0.12%)		8,053.22
(99.84%)		📈 view plot
🚷 view threshold		11,686.00
(+0.03%)		11,710.95
(99.79%)		📈 view plot
🚷 view threshold		87.00
(+15.64%)		88.49
(98.31%)		📈 view plot
🚷 view threshold		307.00
(+1.14%)		310.85
(98.76%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,741.00
(+1.15%)		4,785.93
(99.06%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.96
(98.95%)		📈 view plot
🚷 view threshold		2,276.00
(-0.10%)		2,299.51
(98.98%)		📈 view plot
🚷 view threshold		10.00
(+4.75%)		15.94
(62.73%)		📈 view plot
🚷 view threshold		69.00
(+2.27%)		70.05
(98.50%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,248.00
(+0.61%)		16,307.28
(99.64%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.96
(99.73%)		📈 view plot
🚷 view threshold		8,653.00
(-0.13%)		8,691.60
(99.56%)		📈 view plot
🚷 view threshold		49.00
(+22.36%)		54.40
(90.07%)		📈 view plot
🚷 view threshold		210.00
(+0.90%)		211.90
(99.10%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,794.00
(+0.60%)		35,892.21
(99.73%)		📈 view plot
🚷 view threshold		14,888.00
(+0.16%)		14,910.42
(99.85%)		📈 view plot
🚷 view threshold		21,864.00
(+0.12%)		21,908.75
(99.80%)		📈 view plot
🚷 view threshold		112.00
(+20.51%)		115.29
(97.15%)		📈 view plot
🚷 view threshold		382.00
(+0.69%)		385.09
(99.20%)
🐰 View full continuous benchmarking report in Bencher

@plebhash plebhash added the ready-to-be-merged triggers auto rebase bot label Dec 18, 2024
@pavlenex pavlenex force-pushed the 2024-12-12-fix-codecov-ci-error branch from 33c7b44 to 6bc58b0 Compare December 18, 2024 16:03
@plebhash plebhash merged commit 1351618 into stratum-mining:main Dec 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash approved these changes

Assignees
No one assigned
Labels
ready-to-be-merged triggers auto rebase bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shourya742 @plebhash