change macos-14 to macos-13 #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
=======================================
Coverage 19.29% 19.29%
=======================================
Files 164 164
Lines 10852 10852
=======================================
Hits 2094 2094
Misses 8758 8758
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | 2024-12-18-change-to-macos-13 |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8,422.00 (-0.44%) | 8,678.59 (97.04%) | 📈 view plot 🚷 view threshold | 3,663.00 (-1.97%) | 3,863.81 (94.80%) | 📈 view plot 🚷 view threshold | 5,107.00 (-2.43%) | 5,450.46 (93.70%) | 📈 view plot 🚷 view threshold | 12.00 (+53.29%) | 15.33 (78.26%) | 📈 view plot 🚷 view threshold | 93.00 (+2.17%) | 95.89 (96.98%) |
| get_submit | 📈 view plot 🚷 view threshold | 95,324.00 (-0.07%) | 95,754.35 (99.55%) | 📈 view plot 🚷 view threshold | 59,263.00 (-0.28%) | 59,716.37 (99.24%) | 📈 view plot 🚷 view threshold | 85,074.00 (-0.33%) | 85,831.36 (99.12%) | 📈 view plot 🚷 view threshold | 48.00 (+8.63%) | 59.14 (81.16%) | 📈 view plot 🚷 view threshold | 286.00 (+1.96%) | 290.43 (98.47%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7,935.00 (-0.94%) | 8,233.03 (96.38%) | 📈 view plot 🚷 view threshold | 2,758.00 (-2.32%) | 2,942.22 (93.74%) | 📈 view plot 🚷 view threshold | 3,830.00 (-2.84%) | 4,141.75 (92.47%) | 📈 view plot 🚷 view threshold | 16.00 (+34.65%) | 19.60 (81.64%) | 📈 view plot 🚷 view threshold | 115.00 (+0.41%) | 117.73 (97.68%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12,207.00 (-0.53%) | 12,510.06 (97.58%) | 📈 view plot 🚷 view threshold | 5,240.00 (-1.30%) | 5,428.62 (96.53%) | 📈 view plot 🚷 view threshold | 7,277.00 (-1.63%) | 7,605.76 (95.68%) | 📈 view plot 🚷 view threshold | 13.00 (+34.74%) | 18.21 (71.37%) | 📈 view plot 🚷 view threshold | 139.00 (+0.80%) | 142.11 (97.81%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24,636.00 (-0.30%) | 25,181.67 (97.83%) | 📈 view plot 🚷 view threshold | 9,786.00 (-0.87%) | 10,030.56 (97.56%) | 📈 view plot 🚷 view threshold | 13,786.00 (-1.06%) | 14,198.12 (97.10%) | 📈 view plot 🚷 view threshold | 35.00 (-0.42%) | 45.25 (77.34%) | 📈 view plot 🚷 view threshold | 305.00 (+0.70%) | 313.50 (97.29%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30,231.00 (-0.33%) | 30,709.34 (98.44%) | 📈 view plot 🚷 view threshold | 11,989.00 (-0.62%) | 12,200.55 (98.27%) | 📈 view plot 🚷 view threshold | 16,951.00 (-0.76%) | 17,309.25 (97.93%) | 📈 view plot 🚷 view threshold | 59.00 (+6.28%) | 66.93 (88.16%) | 📈 view plot 🚷 view threshold | 371.00 (+0.11%) | 379.50 (97.76%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126,494.00 (+0.02%) | 126,777.68 (99.78%) | 📈 view plot 🚷 view threshold | 73,117.00 (-0.20%) | 73,525.72 (99.44%) | 📈 view plot 🚷 view threshold | 104,759.00 (-0.26%) | 105,490.76 (99.31%) | 📈 view plot 🚷 view threshold | 112.00 (+5.91%) | 124.04 (90.29%) | 📈 view plot 🚷 view threshold | 605.00 (+1.26%) | 607.70 (99.56%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27,875.00 (-0.07%) | 28,452.81 (97.97%) | 📈 view plot 🚷 view threshold | 9,577.00 (-0.66%) | 9,755.38 (98.17%) | 📈 view plot 🚷 view threshold | 13,515.00 (-0.85%) | 13,829.54 (97.73%) | 📈 view plot 🚷 view threshold | 72.00 (+12.96%) | 76.46 (94.17%) | 📈 view plot 🚷 view threshold | 400.00 (+0.40%) | 412.23 (97.03%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115,219.00 (-0.03%) | 115,729.06 (99.56%) | 📈 view plot 🚷 view threshold | 67,894.00 (-0.27%) | 68,421.71 (99.23%) | 📈 view plot 🚷 view threshold | 97,354.00 (-0.34%) | 98,288.31 (99.05%) | 📈 view plot 🚷 view threshold | 73.00 (+14.62%) | 83.85 (87.06%) | 📈 view plot 🚷 view threshold | 500.00 (+1.48%) | 501.29 (99.74%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23,252.00 (-0.25%) | 23,857.67 (97.46%) | 📈 view plot 🚷 view threshold | 8,129.00 (-0.81%) | 8,312.32 (97.79%) | 📈 view plot 🚷 view threshold | 11,422.00 (-1.01%) | 11,738.38 (97.30%) | 📈 view plot 🚷 view threshold | 42.00 (+10.66%) | 48.38 (86.81%) | 📈 view plot 🚷 view threshold | 332.00 (+0.33%) | 343.90 (96.54%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99,789.00 (-0.03%) | 100,193.45 (99.60%) | 📈 view plot 🚷 view threshold | 61,325.00 (-0.25%) | 61,743.05 (99.32%) | 📈 view plot 🚷 view threshold | 87,929.00 (-0.31%) | 88,659.89 (99.18%) | 📈 view plot 🚷 view threshold | 55.00 (+17.16%) | 64.72 (84.98%) | 📈 view plot 🚷 view threshold | 331.00 (+1.76%) | 335.69 (98.60%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11,418.00 (+0.09%) | 11,612.62 (98.32%) | 📈 view plot 🚷 view threshold | 4,111.00 (-1.46%) | 4,282.62 (95.99%) | 📈 view plot 🚷 view threshold | 5,688.00 (-1.92%) | 5,994.56 (94.89%) | 📈 view plot 🚷 view threshold | 19.00 (+44.59%) | 22.11 (85.94%) | 📈 view plot 🚷 view threshold | 161.00 (+1.67%) | 163.52 (98.46%) |
|
| Branch | 2024-12-18-change-to-macos-13 |
| Testbed | sv2 |
🚨 4 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| client_sv2_handle_message_mining | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 42.00 (+18.34%) | 41.83 (100.41%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 100.00 (+21.17%) | 95.98 (104.19%) |
| client_sv2_open_channel_serialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 47.00 (+31.84%) | 46.30 (101.51%) |
| client_sv2_open_channel_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 94.00 (+25.23%) | 87.96 (106.87%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2,095.00 (-0.57%) | 2,222.08 (94.28%) | 📈 view plot 🚷 view threshold | 473.00 (-0.06%) | 489.01 (96.73%) | 📈 view plot 🚷 view threshold | 735.00 (-0.08%) | 758.01 (96.96%) | 📈 view plot 🚷 view threshold | 6.00 (+16.01%) | 13.14 (45.66%) | 📈 view plot 🚷 view threshold | 38.00 (-1.16%) | 41.47 (91.63%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8,330.00 (+1.36%) | 8,372.31 (99.49%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.02%) | 2,142.82 (99.73%) | 📈 view plot 🚷 view threshold | 3,150.00 (-0.31%) | 3,171.23 (99.33%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 42.00 (+18.34%) | 41.83 (100.41%) | 📈 view plot 🚷 view threshold | 142.00 (+1.83%) | 143.69 (98.82%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6,289.00 (-0.11%) | 6,436.65 (97.71%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.05%) | 1,767.25 (99.02%) | 📈 view plot 🚷 view threshold | 2,549.00 (-0.13%) | 2,575.87 (98.96%) | 📈 view plot 🚷 view threshold | 20.00 (+17.11%) | 24.43 (81.86%) | 📈 view plot 🚷 view threshold | 104.00 (-0.50%) | 108.43 (95.92%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14,734.00 (+0.07%) | 14,938.39 (98.63%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.02%) | 4,711.25 (99.63%) | 📈 view plot 🚷 view threshold | 6,744.00 (-0.20%) | 6,786.03 (99.38%) | 📈 view plot 🚷 view threshold | 58.00 (+30.29%) | 59.46 (97.55%) | 📈 view plot 🚷 view threshold | 220.00 (-0.57%) | 226.65 (97.06%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27,756.00 (+0.67%) | 27,964.40 (99.25%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.43%) | 10,677.82 (99.69%) | 📈 view plot 🚷 view threshold | 15,496.00 (+0.45%) | 15,559.87 (99.59%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 100.00 (+21.17%) | 95.98 (104.19%) | 📈 view plot 🚷 view threshold | 336.00 (+0.24%) | 342.19 (98.19%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4,451.00 (+1.47%) | 4,541.41 (98.01%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.02%) | 1,477.01 (98.92%) | 📈 view plot 🚷 view threshold | 2,156.00 (-0.21%) | 2,183.65 (98.73%) | 📈 view plot 🚷 view threshold | 11.00 (+33.08%) | 14.53 (75.69%) | 📈 view plot 🚷 view threshold | 64.00 (+2.54%) | 66.83 (95.76%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14,026.00 (+0.06%) | 14,192.11 (98.83%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.01%) | 5,080.01 (99.68%) | 📈 view plot 🚷 view threshold | 7,316.00 (-0.14%) | 7,351.33 (99.52%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 47.00 (+31.84%) | 46.30 (101.51%) | 📈 view plot 🚷 view threshold | 185.00 (-0.58%) | 191.14 (96.79%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22,792.00 (+0.51%) | 22,969.89 (99.23%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.12%) | 8,052.26 (99.85%) | 📈 view plot 🚷 view threshold | 11,682.00 (-0.00%) | 11,710.42 (99.76%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 94.00 (+25.23%) | 87.96 (106.87%) | 📈 view plot 🚷 view threshold | 304.00 (+0.19%) | 310.57 (97.88%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4,681.00 (-0.11%) | 4,783.45 (97.86%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.02%) | 1,518.01 (98.95%) | 📈 view plot 🚷 view threshold | 2,276.00 (-0.09%) | 2,299.50 (98.98%) | 📈 view plot 🚷 view threshold | 12.00 (+23.97%) | 16.42 (73.08%) | 📈 view plot 🚷 view threshold | 67.00 (-0.61%) | 69.99 (95.73%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16,154.00 (+0.05%) | 16,297.85 (99.12%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.00%) | 5,979.01 (99.73%) | 📈 view plot 🚷 view threshold | 8,654.00 (-0.12%) | 8,691.42 (99.57%) | 📈 view plot 🚷 view threshold | 51.00 (+27.45%) | 54.27 (93.98%) | 📈 view plot 🚷 view threshold | 207.00 (-0.51%) | 211.76 (97.75%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35,726.00 (+0.43%) | 35,867.33 (99.61%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.17%) | 14,907.52 (99.87%) | 📈 view plot 🚷 view threshold | 21,866.00 (+0.13%) | 21,905.62 (99.82%) | 📈 view plot 🚷 view threshold | 112.00 (+21.09%) | 113.22 (98.93%) | 📈 view plot 🚷 view threshold | 380.00 (+0.19%) | 384.84 (98.74%) |
|
| Branch | 2024-12-18-change-to-macos-13 |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,745.90 (+1.69%) | 7,087.84 (95.18%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,698.10 (+2.73%) | 8,075.30 (95.33%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 8,281.70 (+1.51%) | 9,443.94 (87.69%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 858.02 (-0.80%) | 936.56 (91.61%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 673.73 (+0.21%) | 716.09 (94.08%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 247.21 (-0.66%) | 271.71 (90.98%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 155.99 (-0.76%) | 166.81 (93.51%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,538.40 (+1.75%) | 7,030.51 (93.00%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 277.30 (-1.61%) | 319.40 (86.82%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 725.74 (-0.14%) | 777.21 (93.38%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 588.52 (+0.21%) | 614.19 (95.82%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 204.65 (-0.88%) | 224.91 (90.99%) |
plebhash
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to
macos-14still use the latest macOS 14 runner. This PR aims to switch the macOS runner to version 13 to resolve the 'permission denied' error on macOS.