const_sv2: remove unused dep (secp256k1) #1237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
=======================================
Coverage 19.36% 19.36%
=======================================
Files 164 164
Lines 10811 10811
=======================================
Hits 2094 2094
Misses 8717 8717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | 1237/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,316.00 | 📈 view plot | 3,663.00 | 📈 view plot | 5,111.00 | 📈 view plot | 11.00 | 📈 view plot | 90.00 |
| get_submit | 📈 view plot | 95,164.00 | 📈 view plot | 59,263.00 | 📈 view plot | 85,084.00 | 📈 view plot | 42.00 | 📈 view plot | 282.00 |
| get_subscribe | 📈 view plot | 7,879.00 | 📈 view plot | 2,758.00 | 📈 view plot | 3,829.00 | 📈 view plot | 19.00 | 📈 view plot | 113.00 |
| serialize_authorize | 📈 view plot | 12,071.00 | 📈 view plot | 5,240.00 | 📈 view plot | 7,281.00 | 📈 view plot | 13.00 | 📈 view plot | 135.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,512.00 | 📈 view plot | 9,786.00 | 📈 view plot | 13,787.00 | 📈 view plot | 38.00 | 📈 view plot | 301.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,323.00 | 📈 view plot | 11,989.00 | 📈 view plot | 16,943.00 | 📈 view plot | 65.00 | 📈 view plot | 373.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,180.00 | 📈 view plot | 73,117.00 | 📈 view plot | 104,770.00 | 📈 view plot | 110.00 | 📈 view plot | 596.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 27,871.00 | 📈 view plot | 9,577.00 | 📈 view plot | 13,516.00 | 📈 view plot | 71.00 | 📈 view plot | 400.00 |
| serialize_deserialize_submit | 📈 view plot | 114,789.00 | 📈 view plot | 67,894.00 | 📈 view plot | 97,379.00 | 📈 view plot | 59.00 | 📈 view plot | 489.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,116.00 | 📈 view plot | 8,129.00 | 📈 view plot | 11,426.00 | 📈 view plot | 42.00 | 📈 view plot | 328.00 |
| serialize_submit | 📈 view plot | 99,473.00 | 📈 view plot | 61,325.00 | 📈 view plot | 87,948.00 | 📈 view plot | 44.00 | 📈 view plot | 323.00 |
| serialize_subscribe | 📈 view plot | 11,214.00 | 📈 view plot | 4,111.00 | 📈 view plot | 5,694.00 | 📈 view plot | 19.00 | 📈 view plot | 155.00 |
|
| Branch | 1237/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,095.00 | 📈 view plot | 473.00 | 📈 view plot | 735.00 | 📈 view plot | 6.00 | 📈 view plot | 38.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,158.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,163.00 | 📈 view plot | 33.00 | 📈 view plot | 138.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,251.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,551.00 | 📈 view plot | 19.00 | 📈 view plot | 103.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,606.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,761.00 | 📈 view plot | 43.00 | 📈 view plot | 218.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,438.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,403.00 | 📈 view plot | 83.00 | 📈 view plot | 332.00 |
| client_sv2_open_channel | 📈 view plot | 4,375.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,160.00 | 📈 view plot | 9.00 | 📈 view plot | 62.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,974.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,329.00 | 📈 view plot | 34.00 | 📈 view plot | 185.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,651.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,671.00 | 📈 view plot | 82.00 | 📈 view plot | 302.00 |
| client_sv2_setup_connection | 📈 view plot | 4,673.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,278.00 | 📈 view plot | 10.00 | 📈 view plot | 67.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,106.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,666.00 | 📈 view plot | 39.00 | 📈 view plot | 207.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,446.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,826.00 | 📈 view plot | 92.00 | 📈 view plot | 376.00 |
|
| Branch | 1237/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.08 |
| client_sv2_handle_message_mining | 📈 view plot | 74.93 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.66 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 262.50 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 590.76 |
| client_sv2_open_channel | 📈 view plot | 148.44 |
| client_sv2_open_channel_serialize | 📈 view plot | 282.63 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 402.10 |
| client_sv2_setup_connection | 📈 view plot | 158.78 |
| client_sv2_setup_connection_serialize | 📈 view plot | 489.64 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 945.48 |
|
hey @Georges760 thanks for this contribution can you elaborate on the rationale that motivated this contribution? |
|
#1130 ask to no_std noise_sv2, so I asked in Discord dev channel if I can give it a try. Doing so, I first had to understand the dependencies graph so I wrote a mermaid graph that ended in #1233 and used #1230 to unify the no_std nature of protocol/sv2/* crates. |
ah ok! sorry I missed that discussion on Discord while I was away for a few days thank you for the context, I just caught up on that discussion |
There was a problem hiding this comment.
Since we are going to refactor a bit this crate (look at #1135), it's ok to merge this PR now, but I want to underline that we are not going to bump the version of this crate for this tiny change. We will do it after the refactoring.
const_sv2 does depend on secp256k1 anymore