fix cargo warnings in roles #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbesraa
force-pushed
the
2024-10-08-fix-cargo-warnings-in-roles
branch
from
1450d80 to
ad04857
Compare
Bencher Report
|
| Branch | 1191/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.66 |
| client_sv2_handle_message_mining | 📈 view plot | 72.87 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.67 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 280.13 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 576.80 |
| client_sv2_open_channel | 📈 view plot | 161.48 |
| client_sv2_open_channel_serialize | 📈 view plot | 278.80 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 378.60 |
| client_sv2_setup_connection | 📈 view plot | 155.93 |
| client_sv2_setup_connection_serialize | 📈 view plot | 440.95 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 1,016.10 |
|
| Branch | 1191/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,587.00 | 📈 view plot | 3,772.00 | 📈 view plot | 5,292.00 | 📈 view plot | 8.00 | 📈 view plot | 93.00 |
| get_submit | 📈 view plot | 95,472.00 | 📈 view plot | 59,522.00 | 📈 view plot | 85,507.00 | 📈 view plot | 47.00 | 📈 view plot | 278.00 |
| get_subscribe | 📈 view plot | 8,110.00 | 📈 view plot | 2,848.00 | 📈 view plot | 3,980.00 | 📈 view plot | 14.00 | 📈 view plot | 116.00 |
| serialize_authorize | 📈 view plot | 12,366.00 | 📈 view plot | 5,343.00 | 📈 view plot | 7,456.00 | 📈 view plot | 9.00 | 📈 view plot | 139.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,897.00 | 📈 view plot | 9,920.00 | 📈 view plot | 14,017.00 | 📈 view plot | 34.00 | 📈 view plot | 306.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,409.00 | 📈 view plot | 12,097.00 | 📈 view plot | 17,139.00 | 📈 view plot | 57.00 | 📈 view plot | 371.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,475.00 | 📈 view plot | 73,363.00 | 📈 view plot | 105,195.00 | 📈 view plot | 112.00 | 📈 view plot | 592.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 27,987.00 | 📈 view plot | 9,666.00 | 📈 view plot | 13,677.00 | 📈 view plot | 62.00 | 📈 view plot | 400.00 |
| serialize_deserialize_submit | 📈 view plot | 115,415.00 | 📈 view plot | 68,223.00 | 📈 view plot | 97,935.00 | 📈 view plot | 66.00 | 📈 view plot | 490.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,431.00 | 📈 view plot | 8,225.00 | 📈 view plot | 11,591.00 | 📈 view plot | 37.00 | 📈 view plot | 333.00 |
| serialize_submit | 📈 view plot | 99,865.00 | 📈 view plot | 61,566.00 | 📈 view plot | 88,350.00 | 📈 view plot | 49.00 | 📈 view plot | 322.00 |
| serialize_subscribe | 📈 view plot | 11,439.00 | 📈 view plot | 4,195.00 | 📈 view plot | 5,839.00 | 📈 view plot | 14.00 | 📈 view plot | 158.00 |
|
| Branch | 1191/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,107.00 | 📈 view plot | 473.00 | 📈 view plot | 732.00 | 📈 view plot | 9.00 | 📈 view plot | 38.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,216.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,156.00 | 📈 view plot | 39.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,297.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,547.00 | 📈 view plot | 22.00 | 📈 view plot | 104.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,656.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,756.00 | 📈 view plot | 47.00 | 📈 view plot | 219.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,472.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,402.00 | 📈 view plot | 83.00 | 📈 view plot | 333.00 |
| client_sv2_open_channel | 📈 view plot | 4,341.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,161.00 | 📈 view plot | 9.00 | 📈 view plot | 61.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,926.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,326.00 | 📈 view plot | 39.00 | 📈 view plot | 183.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,673.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,673.00 | 📈 view plot | 79.00 | 📈 view plot | 303.00 |
| client_sv2_setup_connection | 📈 view plot | 4,677.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,277.00 | 📈 view plot | 11.00 | 📈 view plot | 67.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,106.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,666.00 | 📈 view plot | 39.00 | 📈 view plot | 207.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,480.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,825.00 | 📈 view plot | 92.00 | 📈 view plot | 377.00 |
jbesraa
force-pushed
the
2024-10-08-fix-cargo-warnings-in-roles
branch
from
ad04857 to
33d48d8
Compare
|
Rebased without changes |
plebhash
approved these changes
Oct 10, 2024
.. should be examined later to check if need to be removed
pavlenex
force-pushed
the
2024-10-08-fix-cargo-warnings-in-roles
branch
from
33d48d8 to
bdfab4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1096