-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for auth failure between mining_device
and a pool
#1164
Closed
jbesraa
wants to merge
10
commits into
stratum-mining:main
from
jbesraa:2024-09-12-pool-downstream-failure-int-test
+1,380
−1,267
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
14a44aa
Remove unused fn
jbesraa 261e818
Add error handling to `PoolSv2::start`
jbesraa ac99a06
Add `PoolSv2::state`
jbesraa a4033af
Add networking/port test utils fn(s)
jbesraa 02c4dc3
Add `TestPoolSv2` test module
jbesraa 3a80407
Add integration test for `PoolSv2`
jbesraa e23fbe6
Separate `lib` code from `bin` in `mining-device`
jbesraa b49416c
Handle `mining_device` open channel error case
jbesraa 08afc09
Save dropped `PoolSv2` downstreams
jbesraa 4ae9608
Add integration test for mining device auth..
jbesraa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -61,6 +61,7 @@ pub enum Error { | |||||
HashrateError(InputError), | ||||||
LogicErrorMessage(std::boxed::Box<AllMessages<'static>>), | ||||||
JDSMissingTransactions, | ||||||
MiningChannelError(u32), | ||||||
} | ||||||
|
||||||
impl From<BinarySv2Error> for Error { | ||||||
|
@@ -153,6 +154,7 @@ impl Display for Error { | |||||
HashrateError(e) => write!(f, "Impossible to get Hashrate: {:?}", e), | ||||||
LogicErrorMessage(e) => write!(f, "Message is well formatted but can not be handled: {:?}", e), | ||||||
JDSMissingTransactions => write!(f, "JD server cannot propagate the block: missing transactions"), | ||||||
MiningChannelError(e) => write!(f, "Mining channel error: {:?}", e), | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we come up with a more descriptive error message here?
Suggested change
|
||||||
} | ||||||
} | ||||||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add this error type? Also, let's not prepend the variant with the word
Error
as it is redundant.