-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.2
#1112
Merged
Release 1.0.2
#1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-from-upstream Translator restart if disconnected from upstream
…les-logic-sv2 bypass `cargo semver-checks --all-features` for roles_logic_sv2
patch `roles_logic_sv2` `with_serde` flag
use rust stable for semver CI
update `roles/Cargo.lock`
fixed the fallback to solo-mining in the case that the upstream sends a `SubmitShareError` on a valid share AND there are no other available upstreams in the JDC config.
…lo-mining Fix JDC fallback to solo-mining
rm `release-bin.yaml`
In no-serde-sv2 an sv2 sequence is generic over T. If we want this sequence to be Deserialize we need T to be Fixed and GerMarker. This 2 traits were private since all the sv2 types are already defined in no-serde-sv2. But if we want to use sv2 types defined in an sv2 extensions we need to make these traits public. The Encodable dervive macro in derive_codec implement GetSize for the passed struct. But GetSize is also a blanket implementation for every type that implement Fixed. So if we implement Fixed for our new sv2 type and then we derive Encodable (commonly renamed Serialize) we get an error. This commit add an attribute to Encodable called already_sized if the struct that we want derive Encodable is market as already_sized the macro will not implement GetSize for it. This commit also bump minor version of derive_codec and no-serde-sv2 consequentially also of binary-sv2 since it reexport the above libs.
Add support for data types defined by sv2 extensions
Bencher
🚨 9 ALERTS: Threshold Boundary Limits exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
In order to implement Encodable (aka Serialize) for sv2 type defined by extensions EncodablePrimitive is needed.
Update binary-sv2/no-serde-sv2 excport EncodablePrimitive
Remove lib versioning script
rrybarczyk
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global Release
v1.0.2
PR Changelog
bosminer
subscribe edge case #965README.md
#967TemplateDistributionTypes
case #960translation-proxy-old-share.sh
permission #1000jd-client
config error #987CONTRIBUTION.MD
#991GetSize
forSubmitSolutionJd
#1019SubmitSolution
as a valid JD message #1003Framing
crate refactor: cleanupheader.rs
and removeFrame
trait #976Framing
crate refactor: cleanupframing.rs
#982ActionResult::SustainConnection
to MG #1024Cargo.lock
files with version updates #933Aggregate MG Test Results
job to MG CI #1060Aggregate MG Test Results
job to MG CI #1064framing_sv2
#848SubmitSolution
with missing txs #1025test_diff_management
test #995test_diff_management
: adjusttotal_run_time
to 60s #1075no_std
into an optional feature onprotocols
crates #932impl
forSeq0255
onbinary_sv2/serde-sv2
#1085TryInto
ontemplate_distribution_sv2
#1086common_messages_sv2
version #1088roles_logic_sv2
version #1089binary_sv2
version #1090cargo semver-checks --all-features
for roles_logic_sv2 #1100roles_logic_sv2
with_serde
flag #1101roles/Cargo.lock
#1103release-bin.yaml
#1109