-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust docs for protocols::v2::codec-sv2
#1040
Merged
GitGab19
merged 16 commits into
stratum-mining:main
from
rrybarczyk:2024-07-rust-docs-protocols-codec-sv2
Oct 14, 2024
Merged
Rust docs for protocols::v2::codec-sv2
#1040
GitGab19
merged 16 commits into
stratum-mining:main
from
rrybarczyk:2024-07-rust-docs-protocols-codec-sv2
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrybarczyk
added
documentation
Improvements or additions to documentation
protocols
Lowest level protocol logic
codec-sv2
labels
Jul 5, 2024
Bencher
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
This comment was marked as resolved.
This comment was marked as resolved.
78 tasks
rrybarczyk
commented
Jul 6, 2024
@rrybarczyk let me know when you want a review here |
Fi3
reviewed
Jul 10, 2024
Fi3
reviewed
Jul 10, 2024
Fi3
reviewed
Jul 10, 2024
Fi3
reviewed
Jul 10, 2024
Fi3
reviewed
Jul 10, 2024
Fi3
reviewed
Jul 10, 2024
@rrybarczyk make sure you also add a descriptive |
Merged
Bencher Report
Click to view all benchmark results
|
Bencher Report
🚨 14 ALERTS: Threshold Boundary Limits exceeded!
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
GitGab19
approved these changes
Oct 14, 2024
Co-authored-by: plebhash <[email protected]>
rrybarczyk
force-pushed
the
2024-07-rust-docs-protocols-codec-sv2
branch
from
October 14, 2024 16:16
85ecbd5
to
ba3dbdd
Compare
plebhash
approved these changes
Oct 14, 2024
pavlenex
force-pushed
the
2024-07-rust-docs-protocols-codec-sv2
branch
from
October 14, 2024 16:43
ba3dbdd
to
d10dc8d
Compare
Hey @rrybarczyk, your PR cannot be rebased due to conflicts. Could you resolve them, please? |
plebhash
force-pushed
the
2024-07-rust-docs-protocols-codec-sv2
branch
from
October 14, 2024 17:05
d10dc8d
to
a975771
Compare
rrybarczyk
force-pushed
the
2024-07-rust-docs-protocols-codec-sv2
branch
from
October 14, 2024 17:13
a975771
to
fbef904
Compare
Shourya742
approved these changes
Oct 14, 2024
rrybarczyk
force-pushed
the
2024-07-rust-docs-protocols-codec-sv2
branch
from
October 14, 2024 17:28
e4d7d55
to
7356d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
codec-sv2
documentation
Improvements or additions to documentation
protocols
Lowest level protocol logic
ready-to-be-merged
triggers auto rebase bot
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1012.
See discussion for potential code debt discovered during this documentation effort in this discussion.