Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query denoms by admin #25

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Dec 10, 2024

This PR allows one to list denoms currently owned by a given administrator.

Fixes #24

@fmorency
Copy link
Contributor Author

cc @Reecepbcups

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 35.55556% with 29 lines in your changes missing coverage. Please review.

Project coverage is 60.43%. Comparing base (9f137b7) to head (dbda9f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/tokenfactory/client/cli/query.go 0.00% 23 Missing ⚠️
x/tokenfactory/keeper/admins.go 80.00% 2 Missing and 1 partial ⚠️
x/tokenfactory/keeper/grpc_query.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   60.27%   60.43%   +0.15%     
==========================================
  Files          44       44              
  Lines        2787     3556     +769     
==========================================
+ Hits         1680     2149     +469     
- Misses        960     1258     +298     
- Partials      147      149       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this 1 thing then I can merge & tag new

x/tokenfactory/keeper/admins.go Show resolved Hide resolved
@Reecepbcups Reecepbcups merged commit 59eb848 into strangelove-ventures:main Dec 10, 2024
9 of 10 checks passed
@fmorency fmorency deleted the denoms-by-admin branch December 10, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query denoms by admin
2 participants