sdk v50 proposal compatibility #840
Conversation
|
Ahhh we need to be backwards compatibility for SDK v47 (v7) ->v50 (v8) upgrades So multiple structs will be required. Suffix based off the IBC go version instead of SDK |
| @@ -439,7 +444,9 @@ func (c *CosmosChain) SubmitProposal(ctx context.Context, keyName string, prop T | |||
| } | |||
|
|
|||
| // Build a gov v1 proposal type. | |||
| func (c *CosmosChain) BuildProposal(messages []cosmosproto.Message, title, summary, metadata, depositStr string) (TxProposalv1, error) { | |||
| // | |||
| // The proposer field should only be set for IBC-Go v8 / SDK v50 chains. | |||
There was a problem hiding this comment.
We should also add some sort of note that the expedited field is also not ingested for non-sdk50 chains.
There was a problem hiding this comment.
this will not matter so long as proposer is blank. Will error out if they try anything for legacy chains
There was a problem hiding this comment.
Wait how does depositStr come into play here?
There was a problem hiding this comment.
oops! sorry I mis-copied proposer
There was a problem hiding this comment.
Copy that. It was more of a guidance thing for users. But yea, it's self explanatory, should be fine.
(used in x/POA module)
SDK v50 added more governance params in the proposal.json.
The new functions are suffixed with the IBC Go / interchaintest version (ex: BuildProposal and BuildProposalV8). Should we instead prefix with SDK versions?
after merge todo