Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP: main <- #1087] fix(main)!: check transactions succeed after they're included in a block #1095

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 24, 2024

Summary

Sometimes a transaction returns code 0 initially, but then fails when a validator goes to actually include it in a block. This PR adds code to cosmos' ExecTx to make sure transactions are verified after their inclusion in a block; if they fail at any stage of proceedings, an error is returned.


This is an automatic backport of pull request #1087 done by Mergify.

…1087)

(cherry picked from commit a3d5c18)

# Conflicts:
#	examples/cosmos/chain_miscellaneous_test.go
@mergify mergify bot requested a review from a team as a code owner April 24, 2024 16:39
@mergify mergify bot requested a review from pharr117 April 24, 2024 16:39
@mergify mergify bot added the automerge label Apr 24, 2024
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 1:33pm

Copy link
Contributor Author

mergify bot commented Apr 24, 2024

Cherry-pick of a3d5c18 has failed:

On branch mergify/bp/main/pr-1087
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit a3d5c18.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   chain/cosmos/chain_node.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   examples/cosmos/chain_miscellaneous_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@Reecepbcups Reecepbcups changed the title [BP: main <- #1087] fix(v7)!: check transactions succeed after they're included in a block [BP: main <- #1087] fix(main)!: check transactions succeed after they're included in a block Apr 24, 2024
@Reecepbcups Reecepbcups self-requested a review April 24, 2024 16:41
@Reecepbcups Reecepbcups self-assigned this Apr 24, 2024
@Reecepbcups Reecepbcups enabled auto-merge (squash) April 25, 2024 13:33
@Reecepbcups Reecepbcups merged commit 1a0471e into main Apr 25, 2024
18 of 19 checks passed
@Reecepbcups Reecepbcups deleted the mergify/bp/main/pr-1087 branch April 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants