Return empty announcements instead of error; go eth ecrecover lib com…

…patibility
strangelove-ventures · Oct 12, 2023 · 0dcf5ed · 0dcf5ed
1 parent 9ad91ab
commit 0dcf5ed
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/interchaintest/tests/hyperlane_cfg.go b/interchaintest/tests/hyperlane_cfg.go
@@ -43,7 +43,7 @@ func generateHyperlaneValidatorConfig(bech32, privKey, chainID, chainName, rpcUr
 		"chains": {
 		  "%s": {
 			"connection": { "rpc_url": "%s", "grpc_url": "%s", "chain_id": "%s" },
-			"signer": { "type":"cosmosKey", "key": "%s", "prefix": "cosmos", "baseDenom": "stake"},
+			"signer": { "type":"cosmosKey", "key": "%s", "prefix": "cosmos", "base_denom": "stake"},
 			"name": "%s",
 			"domain": %d,
 			"addresses": {

diff --git a/x/announce/keeper/store.go b/x/announce/keeper/store.go
@@ -54,7 +54,7 @@ func (k Keeper) getAnnouncements(ctx sdk.Context, validator []byte) (*types.Stor
 	announcements := &types.StoredAnnouncements{}
 
 	if announceBytes == nil {
-		return nil, errors.New("No announcements stored for validator")
+		return announcements, nil
 	}
 
 	err := announcements.Unmarshal(announceBytes)

diff --git a/x/announce/types/announcement.go b/x/announce/types/announcement.go
@@ -61,6 +61,10 @@ func toEthSignedMessageHash(packedHash []byte) []byte {
 }
 
 func VerifyAnnouncementDigest(digest []byte, signature []byte, expectedSigner []byte) error {
+	if signature[64] >= 4 {
+		signature[64] = signature[64] - 27
+	}
+
 	sigPublicKey, err := crypto.Ecrecover(digest, signature)
 	if err != nil {
 		return err