Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote signer grpc server #215

Merged
merged 13 commits into from
Nov 13, 2023
Merged

remote signer grpc server #215

merged 13 commits into from
Nov 13, 2023

Conversation

agouin
Copy link
Member

@agouin agouin commented Nov 8, 2023

Add additional service to accept privval connections over grpc rather than connect out.
Existing functionality remains the same, this is not a breaking change.

GRPC service is enabled by setting a non-empty grpcAddr string in the config.yaml. This will be used as the listen address. Example: :5555, 0.0.0.0:5555

Service API is minimal and excludes any comet types

service RemoteSigner {
	rpc PubKey (PubKeyRequest) returns (PubKeyResponse) {}
	rpc Sign(strangelove.horcrux.SignBlockRequest) returns (strangelove.horcrux.SignBlockResponse) {}
}

Other:

  • Bump go to 1.21
  • Switch to buf for proto-gen

@agouin agouin marked this pull request as ready for review November 10, 2023 00:45
go.mod Show resolved Hide resolved
@agouin agouin merged commit 706fa2f into main Nov 13, 2023
13 checks passed
@agouin agouin deleted the andrew/remote_signer_grpc_server branch November 13, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants