plugin: restrict characters in plugin names #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, plugin names were allowed to be `1*VCHAR`, which permits path separators and parent directory syntax. Under certain conditions, this could cause `rage` to execute a different binary than intended when launching a plugin. Plugin names are now restricted to alphanumeric characters or +-._ which covers all binary names generally observed in practice.
The existing code was already panicking, but this gives it a nicer error message.
Thanks to ⬡-49016 for reporting this issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 51.32% 52.02% +0.70%
==========================================
Files 43 43
Lines 4195 4219 +24
==========================================
+ Hits 2153 2195 +42
+ Misses 2042 2024 -18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to ⬡-49016 for reporting this issue.
Fixes GHSA-4fg7-vxc8-qx5w.