Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add the Riot.js addon #18672

Closed
wants to merge 1 commit into from

Conversation

GianlucaGuarini
Copy link

@GianlucaGuarini GianlucaGuarini commented Jul 9, 2022

Issue: storybook-eol/riot#1

What I did

I started the setup to support Riot.js > 4

TODO

  • Add tests
  • Test with a demo project

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

Additional notes

Could you please let me know if you will accept this PR?
I am not sure if the Riot.js support is on the top of your priorities since the above issue is 3 years old.
Thank you

@nx-cloud
Copy link

nx-cloud bot commented Jul 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 700f35e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@GianlucaGuarini GianlucaGuarini changed the title WP add the Riot.js addon WIP: add the Riot.js addon Jul 9, 2022
@shilman
Copy link
Member

shilman commented Jul 11, 2022

Hi @GianlucaGuarini thanks for trying to get this working!

We've moved the @storybook/riot repo here: https://github.com/storybookjs/riot. Any interest in maintaining it?

Also, we are making big changes to how frameworks will be supported in Storybook 7, which is the next major release. This is implemented as work in progress on the future/base branch and documented here: https://www.notion.so/chromatic-ui/Frameworks-RFC-89f8aafe3f0941ceb4c24683859ed65c

If you're interested in trying to get Riot working in the SB7 framework, we'd be happy to help guide you in the Storybook Discord: https://discord.gg/storybook

@GianlucaGuarini
Copy link
Author

@shilman thank you for your feedback. Let's continue this conversation on discord. https://discord.com/channels/486522875931656193/486522876388704258/995940589705109505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants