This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
Stop burying stderr output within exec #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exec util buries stderr output. This makes it difficult to understand why your script is failing. Example: Here's how it currently works. Notice there is nothing specific about what went wrong in the error output: ```sh npm run storybook:publish -- --bucket-path=XXXXXXXXXXXXXX => Building storybook for: web executing: build-storybook -o out8599 => Deploying storybook executing: aws --profile default s3 sync out8599 s3://XXXXXXXXXXXXXX /......../node_modules/@storybook/storybook-deployer/src/utils.js:19 throw new Error( ^ Error: Exec code(255) on executing: aws --profile default s3 sync out8599 s3://XXXXXXXXXXXXXX undefined ``` Result: Here's what happens with this patch: ```sh npm run storybook:publish -- --bucket-path=XXXXXXXXXXXXXX => Building storybook for: web executing: build-storybook -o out8599 => Deploying storybook executing: aws --profile default s3 sync out8599 s3://XXXXXXXXXXXXXX The config profile (default) could not be found /......../node_modules/@storybook/storybook-deployer/src/utils.js:19 throw new Error( ^ Error: Exec code(255) on executing: aws --profile default s3 sync out8599 s3://XXXXXXXXXXXXXX undefined ``` We can now see the source of the error as indicated by the command which we executed: > The config profile (default) could not be found
dandean
force-pushed
the
dandean/expose-stderr-output
branch
from
edaa0ec to
31669c5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exec util buries stderr output. This makes it difficult to understand why your script is failing.
Example: Here's how it currently works. Notice there is nothing specific about what went wrong in the error output:
Result: Here's what happens with this patch:
We can now see the source of the error as indicated by the command which we executed: