Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: report only relevant differences for dpre #362

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

landam
Copy link
Member

@landam landam commented Apr 17, 2024

Current diff style:

--- 
+++ 
@@ -1,6 +1,6 @@
 NoDataValue:-9999
 STREAM_RATIO:None
-array_points:[[ 1.      1.      2.      1.1635  7.3094]
 [ 2.     13.      2.      1.3745  1.4116]
 [ 3.     15.      4.      2.2624  0.2335]
 [ 4.     15.      0.      0.2573  0.2646]
 [ 5.     15.      3.      1.8487  0.2891]
 [ 7.      0.      2.      1.1193  7.8153]]
+array_points:[[ 1.          1.          2.          1.16349162  7.30944235]
 [ 2.         13.          2.          1.37450624  1.4115917 ]
 [ 3.         15.          4.          2.26240022  0.23353809]
 [ 4.         15.          0.          0.257301    0.26458773]
 [ 5.         15.          3.          1.84874634  0.28907763]
 [ 7.          0.          2.          1.11926547  7.81530241]]
 bc:None
 br:None
 c:5

New diff style:

--- output (array_points)
+++ reference (array_points)
@@ -1 +1 @@
-array_points:[[ 1.      1.      2.      1.1635  7.3094]
 [ 2.     13.      2.      1.3745  1.4116]
 [ 3.     15.      4.      2.2624  0.2335]
 [ 4.     15.      0.      0.2573  0.2646]
 [ 5.     15.      3.      1.8487  0.2891]
 [ 7.      0.      2.      1.1193  7.8153]]
+array_points:[[ 1.          1.          2.          1.16349162  7.30944235]
 [ 2.         13.          2.          1.37450624  1.4115917 ]
 [ 3.         15.          4.          2.26240022  0.23353809]
 [ 4.         15.          0.          0.257301    0.26458773]
 [ 5.         15.          3.          1.84874634  0.28907763]
 [ 7.          0.          2.          1.11926547  7.81530241]]

@landam landam marked this pull request as draft April 17, 2024 10:11
@landam
Copy link
Member Author

landam commented Apr 17, 2024

Questions:

  • rel / abs tol ?
  • compute diffs only for reported variables?

@pesekon2 pesekon2 added the tests label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants