Issue 115 raise an error if input parameter has a wrong numerical value #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerabekjak
commented
Oct 3, 2022
jerabekjak
commented
Oct 3, 2022
jerabekjak
commented
Oct 3, 2022
This comment was marked as outdated.
This comment was marked as outdated.
jerabekjak
commented
Oct 11, 2022
|
…r-has-a-wrong-numerical-value
landam
requested changes
Oct 13, 2023
| """ Exception raised if a parameter reaches a wrong numeric value | ||
| """ | ||
| def __init__(self,param, value, limit): | ||
| self.msg = "Parameter '{}' has a wrong value ({} > {}).".format( |
There was a problem hiding this comment.
"{} parameter value is too large ({} > {})"
| Logger.info('{} parameter values checked.'.format(name)) | ||
|
|
||
|
|
||
| def _set_output_data(self): |
There was a problem hiding this comment.
where is this new method called?
There was a problem hiding this comment.
I guess it is more of a rhetoric question, but the answer is nowhere (at least at this moment).
Co-authored-by: Martin Landa <[email protected]>
Co-authored-by: Martin Landa <[email protected]>
Co-authored-by: Martin Landa <[email protected]>
Co-authored-by: Martin Landa <[email protected]>
…r-has-a-wrong-numerical-value
|
@jerabekjak Are you planning to work on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.