chore(deps): updating Spectral packages so that Arazzo and AsyncAPI #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankkilcommins
changed the title
YOU54F
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Might want to bump the minimum version of node that is supported in the node engines field, if any of the new packages mandate versions greater
Line 113 in a5c5dcc
Apart from that looks good, will be good to allow users of this extension the benefit of validating AsyncAPI and the new Arazzo based documents
YOU54F
reviewed
Oct 7, 2024
YOU54F
reviewed
Oct 7, 2024
YOU54F
reviewed
Oct 7, 2024
mnaumanali94
approved these changes
Oct 11, 2024
|
Also should update the readme to add Arazzo and new Async version |
@mnaumanali94 - I created #241 for this request |
@mnaumanali94 - nice spot. I've updated the ReadMe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234
Fixes #216
Checklist
Does this PR introduce a breaking change?
Updating Spectral packages so that Arazzo and AsyncAPI linting is included in the VSCode extension.
Also bump node versions on github actions.