fix: empty servers threw an error

Fix #3
stoplightio · Nov 14, 2022 · e3c997f · e3c997f
1 parent a2fb440
commit e3c997f
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 2 deletions.
diff --git a/__tests__/one-api-version-per-document.test.ts b/__tests__/one-api-version-per-document.test.ts
@@ -53,6 +53,35 @@ testRule("one-api-version-per-document", [
 		errors: [],
 	},
 
+  {
+    name: "valid case: no servers defined",
+    document: {
+      openapi: "3.1.0",
+      info: { version: "1.0" },
+    },
+    errors: [],
+  },
+
+  {
+    name: "valid case: empty servers defined",
+    document: {
+      openapi: "3.1.0",
+      info: { version: "1.0" },
+      servers: [],
+    },
+    errors: [],
+  },
+
+  {
+    name: "valid case: weird servers defined",
+    document: {
+      openapi: "3.1.0",
+      info: { version: "1.0" },
+      servers: {},
+    },
+    errors: [],
+  },
+
 	{
 		name: "invalid: multiple versions in directory",
 		document: {

diff --git a/src/functions/onlyOneServerVersion.ts b/src/functions/onlyOneServerVersion.ts
@@ -8,12 +8,16 @@ export default createRulesetFunction({
   options: {
     type: ['null'],
   },
-}, (targetVal: any) => {
+}, (targetVal: Array<any>) => {
+
+  if (! Array.isArray(targetVal)) {
+    return [];
+  }
 
   const versionsMatches = targetVal.map(({ url }: any) => url.match(/([\\.|\\/|](v|version)?[0-9]{1,3}(?:\/)?)/i)[0]);
 
   // If there are fewer than two versions mentioned there cannot be multiple versions
-  if (versionsMatches < 2) {
+  if (versionsMatches.length < 2) {
     return [];
   }