Skip to content

Commit

Permalink
Drop redundant dependencies (#59)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: fetch & AbortController are not polyfilled anymore
  • Loading branch information
P0lip authored Mar 14, 2024
1 parent 067afb3 commit ab6ad5a
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 55 deletions.
9 changes: 4 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2.1

orbs:
node: circleci/[email protected]
browser-tools: circleci/[email protected].4
browser-tools: circleci/[email protected].8

executors:
linux:
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
steps:
- checkout
- node/install:
node-version: << parameters.node-version >>.0
node-version: << parameters.node-version >>
install-yarn: false
install-npm: true
npm-version: "9.7.1"
Expand All @@ -48,7 +48,7 @@ jobs:

test-browser:
docker:
- image: cimg/node:16.13-browsers
- image: cimg/node:16.20-browsers
steps:
- checkout
- browser-tools/install-browser-tools
Expand All @@ -66,6 +66,5 @@ workflows:
os:
- linux
node-version:
- "14.19"
- "16.13"
- "18.19.1"
- test-browser
2 changes: 0 additions & 2 deletions lib/resolvers/http.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
"use strict";

require("isomorphic-fetch");
const { ono } = require("@jsdevtools/ono");
const { AbortController } = require("node-abort-controller");
const url = require("../util/url");
const { ResolverError } = require("../util/errors");

Expand Down
115 changes: 69 additions & 46 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"karma-cli": "^2.0.0",
"mocha": "^8.2.1",
"nock": "^12.0.3",
"node-fetch": "^2.7.0",
"npm-check": "^5.9.0",
"nyc": "^15.0.1",
"shx": "^0.3.2",
Expand All @@ -81,8 +82,6 @@
"@stoplight/yaml": "^4.0.2",
"call-me-maybe": "^1.0.1",
"fastestsmallesttextencoderdecoder": "^1.0.22",
"isomorphic-fetch": "^3.0.0",
"node-abort-controller": "^3.0.1",
"url": "^0.11.3"
}
}

0 comments on commit ab6ad5a

Please sign in to comment.