Merge pull request #53 from stoplightio/fix/2385-external-ref-resolution

add check to not convert actual urls
stoplightio · Oct 9, 2023 · 79a8cda · 79a8cda
2 parents 8d19b3b + b72c855
commit 79a8cda
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/resolve-external.js b/lib/resolve-external.js
@@ -74,8 +74,11 @@ function crawl (obj, path, $refs, options, external, seen) {
     else {
       if (external && $Ref.is$Ref(obj)) {
         /* Correct the reference in the external document so we can resolve it */
-        let withoutHash = url.stripHash(path);
-        obj.$ref = url.toFileSystemPath(withoutHash) + obj.$ref;
+        const withoutHash = url.stripHash(path);
+        const externalRef = url.isHttp(withoutHash)
+          ? withoutHash
+          : url.toFileSystemPath(withoutHash);
+        obj.$ref = externalRef + obj.$ref;
       }
 
       for (let key of Object.keys(obj)) {