https://issues.redhat.com/browse/ACM-15508 - provide more info about extraLabels for SiteConfig #7243
Conversation
amolnar-rh
changed the title
amolnar-rh
force-pushed
the
ACM-15508
branch
from
a8bfb7d to
790a2b1
Compare
amolnar-rh
force-pushed
the
ACM-15508
branch
from
790a2b1 to
f2bf012
Compare
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_install_clusters.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_install_clusters.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
| } | ||
| ---- | ||
| -- |
There was a problem hiding this comment.
Not sure what the dashes are for
| -- |
There was a problem hiding this comment.
Sorry, I was jumping between ACM and OCP PRs, I'm not even sure this works in the ACM build.
Btw, it groups together paragraphs/code snippets that would have different level of indentation without it, which would make it look like one is in the next step. I often have to use the dashes instead of the + signs when they just stop working. I find it's much more reliable than playing around with the +. I attached two pictures from my local preview, hopefully that demonstrates it better :)
-
Without dashes:
-
With dashes:
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
amolnar-rh
force-pushed
the
ACM-15508
branch
2 times, most recently
from
378b9a5 to
c2596a5
Compare
|
/lgtm |
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
amolnar-rh
force-pushed
the
ACM-15508
branch
2 times, most recently
from
d387fb4 to
635dbe3
Compare
| ... | ||
| } | ||
| ---- |
There was a problem hiding this comment.
So I made a commit to remove the two dashes. After doing that, the alignment appears as this now
maybe we should add the dashes back
There was a problem hiding this comment.
Added them back in, should look good now.
mce_acm_integration/siteconfig/siteconfig_installation_templates.adoc
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amolnar-rh, dockerymick, sakhoury The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…extraLabels for SiteConfig
|
New changes are detected. LGTM label has been removed. |
| *Note:* The additional annotations and labels are only applied to the resources that were rendered through the referenced templates. | ||
|
|
||
| View the following example application of extraAnnotations and extraLabels: |
There was a problem hiding this comment.
@amolnar-rh will you monospace the parameters here?
No description provided.