Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ocp version if there is only 1 history item in clusterVersion #755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhiweiyin318
Copy link
Contributor

@zhiweiyin318 zhiweiyin318 commented Jun 5, 2024

issue : https://issues.redhat.com/browse/ACM-12011
will not get the OCP version to the clusterClaim when the history items in the clusterversion only has 1 item and the status is not Completed.
fix: get the OCP version if the history items in the clusterversion only has 1 item, will not check if the item is Completed.

Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
Copy link

sonarqubecloud bot commented Jun 5, 2024

@zhiweiyin318
Copy link
Contributor Author

/assign @elgnay
/assign @zhujian7

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@zhiweiyin318: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 521f8fa link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants