Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade client-go to v0.26.4 #262

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

o-farag
Copy link
Contributor

@o-farag o-farag commented Aug 11, 2023

Description of the change(s):

Why do we need this PR:

Issue reference:

Test API/Unit - Success


@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: o-farag
Once this PR has been reviewed and has the lgtm label, please assign elgnay for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@o-farag
Copy link
Contributor Author

o-farag commented Aug 11, 2023

Current errors:

go fmt ./...
go vet ./...
# k8s.io/apiserver/pkg/server/routes
../go/pkg/mod/k8s.io/[email protected]/pkg/server/routes/openapi.go:44:34: assignment mismatch: 2 variables but handler.NewOpenAPIService returns 1 value
../go/pkg/mod/k8s.io/[email protected]/pkg/server/routes/openapi.go:59:34: assignment mismatch: 2 variables but handler3.NewOpenAPIService returns 1 value
../go/pkg/mod/k8s.io/[email protected]/pkg/server/routes/openapi.go:59:61: too many arguments in call to handler3.NewOpenAPIService
        have (nil)
        want ()
# sigs.k8s.io/cluster-api/api/v1beta1
../go/pkg/mod/sigs.k8s.io/[email protected]/api/v1beta1/machineset_types.go:180:83: not enough arguments in call to metav1validation.ValidateLabelSelector
        have (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, *field.Path)
        want (*"k8s.io/apimachinery/pkg/apis/meta/v1".LabelSelector, validation.LabelSelectorValidationOptions, *field.Path)
# github.com/openshift/library-go/pkg/operator/v1helpers
../go/pkg/mod/github.com/openshift/[email protected]/pkg/operator/v1helpers/informers.go:52:26: implicit function instantiation requires go1.18 or later (-lang was set to go1.17; check go.mod)
../go/pkg/mod/github.com/openshift/[email protected]/pkg/operator/v1helpers/test_helpers.go:23:9: cannot use &fakeSharedIndexInformer{} (value of type *fakeSharedIndexInformer) as type "k8s.io/client-go/tools/cache".SharedIndexInformer in return statement:
        *fakeSharedIndexInformer does not implement "k8s.io/client-go/tools/cache".SharedIndexInformer (wrong type for AddEventHandler method)
                have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
                want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
../go/pkg/mod/github.com/openshift/[email protected]/pkg/operator/v1helpers/test_helpers.go:93:9: cannot use &fakeSharedIndexInformer{} (value of type *fakeSharedIndexInformer) as type "k8s.io/client-go/tools/cache".SharedIndexInformer in return statement:
        *fakeSharedIndexInformer does not implement "k8s.io/client-go/tools/cache".SharedIndexInformer (wrong type for AddEventHandler method)
                have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
                want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
../go/pkg/mod/github.com/openshift/[email protected]/pkg/operator/v1helpers/test_helpers.go:219:9: cannot use &fakeSharedIndexInformer{} (value of type *fakeSharedIndexInformer) as type "k8s.io/client-go/tools/cache".SharedIndexInformer in return statement:
        *fakeSharedIndexInformer does not implement "k8s.io/client-go/tools/cache".SharedIndexInformer (wrong type for AddEventHandler method)
                have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
                want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
make: *** [Makefile:58: vet] Error 2

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants