ACM-5994 - Detect changes from deployment instead of cached secrets

[o-farag]

Description of the change(s):

• Compare state of secrets to state of deployment instead of cached secrets to detect changes

Why do we need this PR:

• Incorrect saving/caching of secrets can cause the operator deployment to be installed with incorrect arguments. This change watches operator deployment args and reinstalls the operator if they differ from expected args. It also removes the intermediate secrets saved in the open-cluster-management-agent-addon namespace

Issue reference:

• https://issues.redhat.com/browse/ACM-5994

Test API/Unit - Success

?       github.com/stolostron/hypershift-addon-operator/cmd     [no test files]
ok      github.com/stolostron/hypershift-addon-operator/pkg/agent       14.211s coverage: 71.2% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/install     173.372s        coverage: 88.0% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/manager     120.100s        coverage: 60.6% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/metrics     0.010s  coverage: 100.0% of statements
?       github.com/stolostron/hypershift-addon-operator/pkg/util        [no test files]

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: o-farag
Once this PR has been reviewed and has the lgtm label, please assign rokej for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[o-farag]

/test all

[o-farag]

/test all

[o-farag]

/retest

[o-farag]

/retest

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

96.9% Coverage
0.0% Duplication

[openshift-ci]

@o-farag: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	8e1ecfd	link	true	/test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.