ACM-5994 Reinstall operator when deployment arguments are mismatched

[o-farag]

Description of the change(s):

• Reinstall operator when operator deployment args change

Why do we need this PR:

• If OIDC args are added after operator is already installed, the operator isn't reinstalled with new args. This change watches operator deployment args and reinstalls the operator if they differ from expected args

Issue reference:

• https://issues.redhat.com/browse/ACM-5994

Test API/Unit - Success

?       github.com/stolostron/hypershift-addon-operator/cmd     [no test files]
ok      github.com/stolostron/hypershift-addon-operator/pkg/agent       13.068s coverage: 71.2% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/install     178.439s        coverage: 86.3% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/manager     120.040s        coverage: 60.6% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/metrics     0.005s  coverage: 100.0% of statements
?       github.com/stolostron/hypershift-addon-operator/pkg/util        [no test files]

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: o-farag
Once this PR has been reviewed and has the lgtm label, please assign philipwu08 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[o-farag]

/test all

[o-farag]

/test all

[o-farag]

/test all

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

92.9% Coverage
0.0% Duplication

[rokej]

@o-farag I think this will work for checking changes in S3 bucket name. This does not catch cases where there was OIDC configuration but not any more... etc.

I am wondering if we can have more generic way to check for changes like https://github.com/stolostron/hypershift-addon-operator/blob/main/pkg/install/hypershift_test.go#L880. Based on user input and secrets, the hypershift install code generates a certain set of args for installing hypershift.

[o-farag]

@o-farag I think this will work for checking changes in S3 bucket name. This does not catch cases where there was OIDC configuration but not any more... etc.

@rokej not completely sure what you mean, could you elaborate more? Doesn't this line: https://github.com/o-farag/hypershift-addon-operator/blob/ce8bc890e78dfb0152ce5c802e2daca58fb380c4/pkg/install/upgrade.go#L222 catch the case where there was OIDC configuration but not anymore?

I am wondering if we can have more generic way to check for changes like https://github.com/stolostron/hypershift-addon-operator/blob/main/pkg/install/hypershift_test.go#L880. Based on user input and secrets, the hypershift install code generates a certain set of args for installing hypershift.

To confirm, a generic way to check for mismatch of all args instead of just OIDC args?