MGMT-19346: Enable 4/5 CPN to Cluster Details Form

[ammont82]

Related to https://issues.redhat.com/browse/MGMT-19346

Need this PR to work: openshift-assisted/assisted-installer-ui#2727

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @ammont82. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rawagner]

no need for switch statement. A simple

Suggested change

	workerAgents: 0
	{{#if ai.controlPlaneAgents}}
	workerAgents: 0
	controlPlaneAgents: {{{ai.controlPlaneAgents}}}

will do

[ammont82]

the problem is that controlPlaneAgents is an string and we need a number

[rawagner]

after fixing openshift-assisted/assisted-installer-ui#2727, we will have a number here.

also cim-template.hbs needs to be updated.

also in order to make the yaml editor -> UI form sync work, we need to update https://github.com/stolostron/console/blob/main/frontend/src/routes/Infrastructure/Clusters/ManagedClusters/CreateCluster/components/assisted-installer/DetailsForm.tsx#L138-L151

by adding the controlPlaneCount

controlPlaneCount: { path: 'AgentClusterInstall[0].spec.provisionRequirements.controlPlaneAgents' },