🐛 Present view on keyWindow over iOS 17 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stleamist
approved these changes
Oct 29, 2023
| guard let presentingViewController = uiView.viewController else { | ||
| self.resetItemBinding() | ||
|
|
||
| if #available(iOS 17.0, *) { |
There was a problem hiding this comment.
Great! I think it would be nice to use your suggestion even on iOS 16 and earlier.
This guarantees that presentingViewController doesn't have a presentedViewController, which means the modal presentation ofSafariViewController will not be blocked by any other presentedViewController.
| self.resetItemBinding() | ||
|
|
||
| if #available(iOS 17.0, *) { | ||
| if var topController = UIApplication.shared.windows.filter(\.isKeyWindow).first?.rootViewController { |
There was a problem hiding this comment.
An UIWindow instance is must be grabbed via uiView.window.
UIApplication.shared.windows is deprecated in iOS 15, and this will make an issue when there are two or more UIWindowScenes.
stleamist
changed the base branch from
develop
to
bug/ios-17-key-press-responder-issue
stleamist
added
bug
|
Relates to #41 |
stleamist
merged commit df7db51
into
stleamist:bug/ios-17-key-press-responder-issue
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a issue that when the view doesn't have the uiViewController, it just reset the binding item. And weirdly, this happens only in iOS 17.
So I present the view on the key window (not uiView.viewController), when in iOS 17.