Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix survival settings type error #2569

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix survival settings type error #2569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa5461d
fix survival settings type error
Jan 7, 2025
e82dda7
add comment
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions shared/types/src/dataset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,10 @@ type SortPriorityEntry = {
type SurvivalSettings = {
/** The max time-to-event to be displayed in plot, hide all the samples with Time-to-Event longer than this maxTimeToEvent */
maxTimeToEvent?: number
/** The time unit (months, years, etc) displayed in the x-axis of survival plot */
timeUnit?: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks could you add comment to explain purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks just added

/** the customized x-axis tick values of survival plot */
xTickValues?: number[]
}

type MatrixSettings = {
Expand Down
Loading