Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Towards #2586) Add support for object-oriented var =[>] this[%...]%procedure(...) assignment #2649

Merged
merged 10 commits into from
Jul 18, 2024

Conversation

JulienRemy
Copy link
Collaborator

Currently pointer assignments of the form var =[>] this[%...]%procedure(...) are CodeBlocks wrapping fparser Function_Reference objects.
This converts them to assignments with a call on the rhs.

Notes:

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (d92f13f) to head (b974455).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2649   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files         352      352           
  Lines       48507    48509    +2     
=======================================
+ Hits        48442    48444    +2     
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arporter
Copy link
Member

Hi @JulienRemy, I can't remember what you said about PRs on Monday. Was this the one that's ready for a review?

@JulienRemy
Copy link
Collaborator Author

Hi @arporter, this one is indeed ready to review when you have time for this.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Julien. Just one small refinement and then this can go on.
No need to update any docs as this is a bug fix/workaround.
I'll fire off the integration tests now.

src/psyclone/psyir/frontend/fparser2.py Outdated Show resolved Hide resolved
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change has been made (thanks).
Integration tests were all green (although I'll re-run them).
Will proceed to merge.

@arporter
Copy link
Member

Integration tests were green.

@arporter arporter merged commit 29bba60 into master Jul 18, 2024
13 checks passed
@arporter arporter deleted the 2586_fparser_function_reference branch July 18, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Calls to StructureType members
2 participants