-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Towards #2586) Add support for object-oriented var =[>] this[%...]%procedure(...)
assignment
#2649
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2649 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 352 352
Lines 48507 48509 +2
=======================================
+ Hits 48442 48444 +2
Misses 65 65 ☔ View full report in Codecov by Sentry. |
Hi @JulienRemy, I can't remember what you said about PRs on Monday. Was this the one that's ready for a review? |
Hi @arporter, this one is indeed ready to review when you have time for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Julien. Just one small refinement and then this can go on.
No need to update any docs as this is a bug fix/workaround.
I'll fire off the integration tests now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested change has been made (thanks).
Integration tests were all green (although I'll re-run them).
Will proceed to merge.
Integration tests were green. |
Currently pointer assignments of the form
var =[>] this[%...]%procedure(...)
areCodeBlock
s wrapping fparserFunction_Reference
objects.This converts them to assignments with a call on the rhs.
Notes:
Intrinsic_Function_Reference
, wrongly parsed asFunction_Reference
fparser/#447 and associated TODO comments.Structure_Constructor
case mentioned here so it does not close Add support for Calls to StructureType members #2586.