Adding support for Pi-hole running inside a Docker container #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev docker support
moving default my-pihole-lists location out of /usr/local/bin
|
Would you mind taking a peak at v5 and see how the docker changes could be rolled in? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a small change to
pihole-cloudsyncin order to support cases where Pi-hole is running inside a Docker container (see: https://github.com/pi-hole/docker-pi-hole). Sorry about the tabs/spaces change, I know that's not exactly being a good citizen, but the meat of the Docker-support change should be pretty easy to merge in as (or if) you see fit.