modified start and build statements #114
Conversation
❌ Deploy Preview for warp-v failed.
|
|
Looks like node would have to be bumped to a newer version in CI (and in my own local environment) in order to merge this change. |
There was a problem hiding this comment.
Looks good. I'll approve it, but this API should be documented as well. https://github.com/stevehoover/warp-v/blob/master/configurator/README.md is probably the right place (even though the original developer did not do a good job with docs).
|
Oops. This still has the issue of breaking deployment due to: /opt/buildhome/.nvm/versions/node/v16.20.2/bin/node: bad option: --openssl-legacy-provider Please look into this as a priority. I did some digging, and I believe this needs a newer version: configurator/package.json: "react-scripts": "4.0.3", |
|
Okay, so the Node.js version is probably causing the compatibility error |
|
The --openssl-legacy-provider option is needed when using the latest version of Node.js, because [Node.js 17 and later uses OpenSSL 3.0] which has had some breaking changes. However older version like v16 (being used in the checks) doesn't seem to require the openssl option in the start and build statements. |
|
I can create a PR with the original build statement inplace ( yarn build) and only the start statement modified, if that is needed |
In newer versions of Node.js, the default provider for OpenSSL has been changed, and this might not be backward compatible with certain older applications or libraries that depend on the legacy behavior of OpenSSL.
The –openssl-legacy-provider flag forces Node.js to use the legacy provider, which is why it resolves the issue.