Test across php versions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o separate workflows, with the latter running across all supported versions of PHP
This is a change for me, but PHP-CS-Fixer/PHP-CS-Fixer#7303 makes a good point for `if (!defined())` being a better match with PSR-12 than `if(! defined())`.
stevegrunwell
force-pushed
the
test-across-php-versions
branch
from
ff2307b to
260c062
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
composer.lockfile (which isn't necessary in a library), which makes it easier to install a range of PHPUnit versions depending on the version of PHP being used.The previous
ci-cd.ymlGitHub Actions workflow has been removed, in favor of separate workflows for PHPUnit and PHP-CS-Fixer, with the former being run across all supported versions of PHP.Replaces & closes #12.