Add multipliers for sub-second timing #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed a PR at work today that included logic that took some number of seconds as an integer, then had to compute the number of milliseconds in order to interact with a Prometheus service. I realized that even if we were using this library, there would still be a
$seconds * 1000
expression somewhere, which means people trying to do [albeit simple] math.This PR adds four "multipliers", representing the most common submultiples of second in the International System of Units:
It's unlikely that nanoseconds nor picoseconds will really get much use, but microseconds are useful when dealing with high-resolution time, and milliseconds are popular for measuring performance, microcaching, and more.