-
Notifications
You must be signed in to change notification settings - Fork 46
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
ffbeecf
commit 13967d9
Showing
2 changed files
with
23 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
### FIXMEs | ||
| Filename | line # | FIXME | ||
|:------|:------:|:------ | ||
| ./src/api/config/environment.config.ts | 17 | encrypt confidential data on env variables (ie typeorm) | ||
| ./src/api/config/passport.config.ts | 68 | promise error is not managed | ||
| ./src/api/config/environment.config.ts | 14 | encrypt confidential data on env variables (ie typeorm) | ||
| ./src/api/models/media.model.ts | 10 | Media fieldname management. Seems to be always 'media'. Check and add e2e tests | ||
| ./src/api/repositories/user.repository.ts | 106 | user should always retrieved from her email address. If not, possible collision on username value | ||
| ./src/api/services/auth.service.ts | 52 | promise error is not managed | ||
| ./src/api/services/auth.service.ts | 78 | promise error is not managed | ||
| ./src/api/utils/string.util.ts | 38 | not working | ||
|
||
### TODOs | ||
| Filename | line # | TODO | ||
|:------|:------:|:------ | ||
| ./src/api/decorators/safe.decorator.ts | 28 | fallback in catch | ||
| ./src/api/middlewares/sanitizer.middleware.ts | 25 | safe decorator ? | ||
| ./src/api/middlewares/sanitizer.middleware.ts | 18 | safe decorator on this middleware and each other |