Filled progressbar #264
Open
Filled progressbar #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #264 +/- ##
==========================================
Coverage 85.41% 85.41%
Complexity 266 266
==========================================
Files 30 30
Lines 994 994
Branches 85 85
==========================================
Hits 849 849
Misses 117 117
Partials 28 28Continue to review full report at Codecov.
|
… (fills width and height of the navigation bar) by setting a ms_stepperLayoutTheme similar to this:
<style name="FilledProgressStepperLayoutTheme" parent="CustomStepperLayoutTheme">
<item name="ms_colorableProgressBarStyle">@style/FilledProgressStepperLayoutStyle</item>
</style>
<style name="FilledProgressStepperLayoutStyle" parent="MSColorableProgressBar">
<item name="android:layout_width">match_parent</item>
<item name="android:layout_height">match_parent</item>
</style>
The progress_bar stepper type can still be used as before by not applying a theme.
(cherry picked from commit 29b8146)
(cherry picked from commit 9fae6bf)
|
Sorry, I tried to merge against master instead of develop. Now it's correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue Filled ProgressBar #263
Slightly changed ms_stepper_layout to allow for a filled progress bar (fills width and height of the navigation bar) by setting a ms_stepperLayoutTheme similar to this:
<style name="FilledProgressStepperLayoutTheme" parent="CustomStepperLayoutTheme">
@style/FilledProgressStepperLayoutStyle
</style>
<style name="FilledProgressStepperLayoutStyle" parent="MSColorableProgressBar">
match_parent
match_parent
</style>
The progress_bar stepper type can still be used as before by not applying a theme.