-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ajax validation unique for each plugin #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MlKilderkin Did you have to make any changes to Flux/Account Pages when testing this? We don't use the do_settings_field()
method as we already have our own settings. We're directly redering the license field, which means the new plugin slug is not set:
/**
* Output license field.
*/
public static function license_field() {
$container = Config::get_container();
$container->get( License_Field::class )->render( false, false );
}
@jamesckemp even in that case render method with call |
And I haven't touch anything in plugin. Only Uplink library has been updated |
@MlKilderkin I get this error:
|
@jamesckemp Could you check that you have
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well 🙌
What
Address #22
Make ajax validation unique for each plugin