Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to standard anonymous functions for 7.3 support #32

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

oakesjosh
Copy link
Contributor

Arrow functions were introduced in PHP 7.4 https://www.php.net/manual/en/functions.arrow.php

Running this on PHP 7.3 results in Parse error: syntax error, unexpected ‘=>’ (T_DOUBLE_ARROW), expecting ‘)’ in /wp-content/plugins/kadence-blocks-pro/vendor/vendor-prefixed/stellarwp/schema/src/Schema/Schema.php on line 70

@oakesjosh oakesjosh requested a review from borkweb November 30, 2023 18:30
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@borkweb borkweb merged commit 818e579 into main Nov 30, 2023
2 checks passed
@borkweb borkweb deleted the php-7-3-anonymous-functions branch November 30, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants