Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/KAD-3623 #628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bugfix/KAD-3623 #628

wants to merge 2 commits into from

Conversation

gilbert-hernandez
Copy link
Contributor

@gilbert-hernandez gilbert-hernandez commented Dec 10, 2024 •
edited
Loading

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3623
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

oakesjosh
oakesjosh requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@oakesjosh oakesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me. CSS that isn't dynamic is a good fit for the editor.scss file. There's CSS applied to the &.kt-btn-width-type-full class. This could live by that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakesjosh oakesjosh oakesjosh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilbert-hernandez @oakesjosh