Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/KAD-3677 #626

Merged
merged 2 commits into from
Dec 11, 2024
Merged

bugfix/KAD-3677 #626

merged 2 commits into from
Dec 11, 2024

Conversation

gilbert-hernandez
Copy link
Contributor

@gilbert-hernandez gilbert-hernandez commented Dec 5, 2024

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-3677
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@gilbert-hernandez
Copy link
Contributor Author

The initial issue was that the slider/carousel galleries weren't showing the shadow the same as the other gallery types. However, there is a note that the sliders and carousels will cutoff shadows due to the way they are hidden. But, I noticed that the thumbnails in the thumbnail sliders weren't showing the shadow on the frontend. This fix is to show the shadows on thumbnails in the slider.

@oakesjosh oakesjosh merged commit 96c9f04 into master Dec 11, 2024
19 checks passed
@oakesjosh oakesjosh deleted the bugfix/KAD-3677 branch December 11, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants